feat(asset): report HOST category and send asset-scoped network fields on registration (#207)#208
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the agent registration payload (src/api/register_agent.rs) to align with the OpenAEV asset taxonomy remodel by emitting canonical asset_* network fields and reporting the asset category as HOST.
Changes:
- Renamed network registration fields from
endpoint_*toasset_*(asset_ips,asset_hostname,asset_mac_addresses). - Added
asset_category: "HOST"to the registration payload. - Kept endpoint-scoped fields unchanged (
endpoint_platform,endpoint_arch,endpoint_agent_version).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
Author
|
Review-and-fix pass complete:
Remaining (non-CI) blocker: the branch protection requires one approving review, and the PR author cannot self-approve - a maintainer approval is the only step left before merge. |
…scope (#207) Resolve the review comment about hostname::get() being called twice in the registration payload (redundant syscall, potential inconsistency between asset_name and asset_hostname if one call fails). Compute it once and reuse it. Also group the payload keys by scope (asset_*, endpoint_*, agent_*) for readability; the wire format is unchanged.
SamuelHassine
force-pushed
the
feature/asset-category-host
branch
from
July 17, 2026 18:59
8d796a0 to
9dd0b83
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adapts the agent registration payload to the OpenAEV asset taxonomy remodel:
The backend keeps a JsonAlias on the legacy endpoint_* names so already-deployed agents keep registering until they self-update; this aligns the agent source with the new canonical wire names used by the platform, injectors, collectors and the Python client.
The implant needs no change (it sends no endpoint_* asset fields).
Closes #207
Test plan