Skip to content

add a list of Disney films - #8

Open
mengzhenxiao wants to merge 1 commit into
Open-Source-Studio-at-ITP:masterfrom
mengzhenxiao:master
Open

add a list of Disney films#8
mengzhenxiao wants to merge 1 commit into
Open-Source-Studio-at-ITP:masterfrom
mengzhenxiao:master

Conversation

@mengzhenxiao

Copy link
Copy Markdown

No description provided.

@shiffman shiffman left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Just the one comment.

@hugovk

hugovk commented Sep 25, 2018

Copy link
Copy Markdown

@shiffman What's the one comment? :)

@shiffman

Copy link
Copy Markdown
Member

@hugovk oh, how odd somehow I missed submitting it with the review? Will re-add!

@@ -0,0 +1,1618 @@
[
{

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the standard format for corpora is to start with an object and then include the list as a named array. It's also good practice to include "description" and "source" properties for more info about the data and where it was compiled from!

{
  "description": "____________",
  "source": "____________",
  "films": [ ]
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants