Aseem - Phase 2 - Add filters for for Predicted vs Actual Cost Line chart and UI changes#5375
Open
aseemdeshmukh wants to merge 6 commits into
Open
Aseem - Phase 2 - Add filters for for Predicted vs Actual Cost Line chart and UI changes#5375aseemdeshmukh wants to merge 6 commits into
aseemdeshmukh wants to merge 6 commits into
Conversation
…tom tool tip Co-authored-by: Copilot <copilot@github.com>
✅ Deploy Preview for highestgoodnetwork-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
HemanthNidamanuru
requested changes
Jul 18, 2026
HemanthNidamanuru
left a comment
There was a problem hiding this comment.
Hi Aseem,
I tested this PR locally. The Financial Tracking features, including tooltips, project and date filters, reset functionality, custom tooltips, pie chart values and percentages, cost variance indicators, and consistent color mapping, are working as expected in dark mode.
However, the calendar is not properly aligned in dark mode, and the SonarQube check is failing. Please review these issues before merging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Description
This PR covers/solves both of these similar tasks:

And also this task:
Related PRS (if any):
This is a redo of PR #4354 Frontend PR, including fixes for all the feedback provided there.
Main changes explained:
How to test:
a) For dark mode, tooltips and texts are readable and can be distinguished --> * tooltip explanations for Planned, Actual, and Predicted costs exist
b) Filters for Projects and date filter work
c) reset filter button works
d) custom tooltip is working
Screenshots or videos of changes:
1.mp4