Anthony/Continuation-For-PR#3917-Role-Change-Permissions-Confirmation-Modal

[AnthonyWeathers]

Description

Took over the work of PR#3917, adjusting it according to feedback and added additional details to keep users aware of the changes they're making while utilizing the modal.

Related PRS (if any):

There is no backend related PR needed for this frontend one.
…

Main changes explained:

• Delete file A for removing unused components …
• Updated BasicInformationTab.jsx to import and use new file that contains the modal while passing in needed values to it
• Created RoleChangePermissionsModal.jsx to allow admin/owner users to change the role of a user, while selecting which modified permissions to keep for the user, if any of the modified ones differ from the permissions of the user's new role.
• Updated UserProfile.jsx to pass in a authUser object that is needed for the RoleChangePermissionsModal.jsx file
  …

How to test:

1. check into current branch
2. do npm install and ... to run this PR locally
3. Clear site data/cache
4. log as admin or owner user (not sure if admin is high enough, would appreciate a check on that)
5. go to dashboard→ Find a user (You can use Anthony Test or Anthony Test2 for testing)→ Go to this profile→ Click Manage Role & Permissions to open modal
6. Change role of the user, and select any permissions that are listed, to keep for added/removed, then save.
7. Verify a success toast is shown
8. If you did not checkbox all of the listed permissions, then go to Permissions Management to check if a permission change log for the user, was created. (A change log would only occur, if there are permission changes on the role change, if you pick a role that happens to have no permissions displayed, or you check boxed all of the permissions shown, then likely no change log is created as there would be no change in the permission list of the user)
9. verify this new feature works in [dark mode]

Screenshots or videos of changes:

Manage Role and Permissions button in Role row on User Profile page

Manage Role and Permissions Modal

Example of Permissions checked with Switch to Testing Role

Success toast after role change save without error

Change log showing the saved changes for Test

Note:

[netlify]

✅ Deploy Preview for highestgoodnetwork-dev ready!

Name	Link
🔨 Latest commit	a35e2ad
🔍 Latest deploy log	https://app.netlify.com/projects/highestgoodnetwork-dev/deploys/6a5a133fe91bf80008395511
😎 Deploy Preview	https://deploy-preview-5340--highestgoodnetwork-dev.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
🤖 Make changes	Run an agent on this branch

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[DeepighaJ]

• Tested the PR locally and the functionality works as expected.
• I'm able to change role, add and delete permission. The changes are reflecting on Permission management logs as well.
• The dark mode needs improvement overall dashboard, permission management pages as well.

[HemanthNidamanuru]

Hi Anthony,

I tested this PR locally.

The role and permission update flow is working fine. The changes save successfully, the success toast is shown, and the feature works in dark mode.

One small issue I noticed is on the Permission Management page in dark mode: when hovering over a row, the row is not clearly visible. The hover color/contrast could be improved for better readability.

[AnthonyWeathers]

Hi Anthony,

I tested this PR locally.

The role and permission update flow is working fine. The changes save successfully, the success toast is shown, and the feature works in dark mode.

One small issue I noticed is on the Permission Management page in dark mode: when hovering over a row, the row is not clearly visible. The hover color/contrast could be improved for better readability.

Thanks for the tip, I modified the styling for the change log table, does it look fine now in dark mode?

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[nathanah]

Great, thank you.