Amaresh taking over for Nikita phase 2 summary dashboard making the horizontal bar graph of p5 fe#4608
Conversation
✅ Deploy Preview for highestgoodnetwork-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
…er arrow contrast
…s, and x-axis scale
… contrast, unused import
kzou55
left a comment
There was a problem hiding this comment.
Hi Amaresh,
I ran and tested the current branch locally(alongside the associated backend).
I can verify that the date and project filter work. And that the dropdown menu for the either Longest Open or Most Expensive Work. And that the elements of the bar chart has the associated values and information.
Video of Test:
- Light Mode
Recording.2026-06-22.174224.mp4
- Dark Mode
Recording.2026-06-22.174845.mp4
Issues:
-
Date Picker:
- Contrast for the date picker's back and forward arrow buttons have low contrast in Light Mode. It only has clear contrast when it's hovered. Note: this is not a problem in Dark Mode.
- Could also have a "x" or clear button to clear the start and end date field. So users can easily know how to reset the date filters.
-
Most Expensive Chart is blank when filtering projects:
Jaden300
left a comment
There was a problem hiding this comment.
Tested locally on branch Nikita-Phase-2-Summary-Dashboard--Making-the-Horizontal-Bar-Graph-of-P5-FE at http://localhost:5173/bmdashboard/totalconstructionsummary logged in as admin.
The chart components render correctly and dark mode styling looks good. However, no graph data appeared during testing - the charts were empty throughout. This may be due to the backend not having test data available in my local environment, as the associated backend PR (#2256) is still open. The previous reviewer was able to see data, so this may be an environment-specific issue rather than a bug in the implementation.
The date filter, project filter dropdown, and Longest Open vs Most Expensive toggle all appear to function as expected based on UI behavior. Approving given the implementation looks correct and dark mode is solid, but recommend verifying data rendering once the backend PR is merged.
…plicate CSS module path
|
|
Hi @kzou55 Thanks for the thorough testing, I resolved the issues you flagged
Could you please re-review when you get a chance?
|
|
Hi @DeepighaJ This should be fixed now Please pull the latest and re-test when you get a chance!
|
There was a problem hiding this comment.
Hello, I reviewed #4608 on my local. This is working as expected.
Passing Cases
-The chart shows data in both dark and light mode.
-The chart loads for total data on both longest-open and expensive issues without date filter.
-The chart shows issues data with startDate, endDate and project filters data on both long-open and expensive issues.
-Upon clearing the filter, the chart shows total issues for all projects.
-The tooltip show useful data for good understanding.




























Description
Related PRS (if any):
This frontend PR is related to the #1463 backend PR. (closed) --> New PR: OneCommunityGlobal/HGNRest#2256
…
Main changes explained:
…
How to test:
npm installandnpm run start:localto run this PR locallyScreenshots or videos of changes:
Demo.webm
Note: The data for the expenses is null in the backend so it shows null
Note:
Include the information the reviewers need to know.
Old PR was removed since branch name isnt up to spec linking for reference here