This repository was archived by the owner on Feb 4, 2022. It is now read-only.
🚑 hotfix for slow read notifications API#530
Open
lifenautjoe wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a hotfix for refreshing the notifications after first load which on profiles with tons of notifications, takes a millenia to load.
This wont wait for the server read notification API call to come back before retrieving new notifications and instead it will mark them as read locally. There is a chance that the data might be out of sync on app reset... however this is preferable than the alternative section taking 10+ seconds to load.
We'll fix the API, this is a temporal fix.