Skip to content
This repository was archived by the owner on Feb 4, 2022. It is now read-only.

Sharing on iOS#233

Open
999eagle wants to merge 18 commits into
OkunaOrg:developfrom
999eagle:feature/share-ios
Open

Sharing on iOS#233
999eagle wants to merge 18 commits into
OkunaOrg:developfrom
999eagle:feature/share-ios

Conversation

@999eagle

@999eagle 999eagle commented Apr 5, 2019

Copy link
Copy Markdown
Member

This PR implements sharing images on iOS directly to Openbook.

@999eagle 999eagle changed the title WIP: Sharing on iOS Sharing on iOS Apr 6, 2019
@999eagle

999eagle commented Apr 6, 2019

Copy link
Copy Markdown
Member Author

In the current state, sharing on iOS works fine from other apps directly to Openbook. There probably are some edge cases when it doesn't work and proper error handling is missing in some places as well.

@lifenautjoe

Copy link
Copy Markdown
Member

Hi Sophie! Tried sharing from the gallery to Openbook and nothing happened, perhaps this is one of those edge cases? It allows to add text as well over there 🤔

@999eagle

999eagle commented Apr 6, 2019 via email

Copy link
Copy Markdown
Member Author

@lifenautjoe

lifenautjoe commented Apr 6, 2019 via email

Copy link
Copy Markdown
Member

@999eagle

999eagle commented Apr 6, 2019 via email

Copy link
Copy Markdown
Member Author

@uiboy

uiboy commented Apr 24, 2019

Copy link
Copy Markdown
Member

@lifenautjoe is this ready to go? was just looking at all the Open PRs

@999eagle

Copy link
Copy Markdown
Member Author

@uiboy there's still a problem with this as it works perfectly fine in the iOS simulator, but when @lifenautjoe tried it on a physical device, nothing happened.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants