fix: preserve upstream user agent#355
Open
iBobbyTS wants to merge 1 commit into
Open
Conversation
Forward the client User-Agent through the explicit upstream header whitelist for proxy and embeddings passthrough requests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
User-Agentheader when forwarding gateway requests upstream.gateway.headersso proxy and passthrough endpoints use the same behavior./v1/embeddingspassthrough requests.Context
The gateway already had an
extra_headerspath through the proxy and transport layers, but the application handlers only populatedx-request-idandOpenResponses-Version. As a result, upstream providers saw the transport/client default user agent instead of the SDK or agent user agent from the incoming request.This keeps the forwarding explicit rather than proxying arbitrary request headers. The whitelist remains limited to
x-request-id,User-Agent, andOpenResponses-Version.Test plan
/Users/ibobby/miniconda3/envs/llm-rosetta/bin/python -m pytest tests/gateway/test_app_headers.py tests/gateway/test_embeddings.py -q— 5 passedPATH=/Users/ibobby/miniconda3/envs/llm-rosetta/bin:$PATH make lintPATH=/Users/ibobby/miniconda3/envs/llm-rosetta/bin:$PATH make test— currently blocked in this local Python 3.14 environment by existingtests/gateway/test_auth.pyfailures usingasyncio.get_event_loop()with no current event loop. This was reproduced on the fork point (origin/master) as well.AI was used to assist with implementation and validation; I reviewed the resulting changes and tests.