Merge PR #2040 into 16.0

Signed-off-by rousseldenis

Author: OCA-git-bot

setup/stock_picking_location_check/odoo/addons/stock_picking_location_check

@@ -0,0 +1 @@
+../../../../stock_picking_location_check

setup/stock_picking_location_check/setup.py

@@ -0,0 +1,6 @@
+import setuptools
+
+setuptools.setup(
+    setup_requires=['setuptools-odoo'],
+    odoo_addon=True,
+)

stock_picking_location_check/README.rst

@@ -0,0 +1,101 @@
+============================
+Stock Picking Location Check
+============================
+
+.. 
+   !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
+   !! This file is generated by oca-gen-addon-readme !!
+   !! changes will be overwritten.                   !!
+   !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
+   !! source digest: sha256:1629c3544e6c20c084a98fd69503dcf4685cc1ff2cf7bbda0b2a5311cc888ba0
+   !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
+
+.. |badge1| image:: https://img.shields.io/badge/maturity-Beta-yellow.png
+    :target: https://odoo-community.org/page/development-status
+    :alt: Beta
+.. |badge2| image:: https://img.shields.io/badge/licence-AGPL--3-blue.png
+    :target: http://www.gnu.org/licenses/agpl-3.0-standalone.html
+    :alt: License: AGPL-3
+.. |badge3| image:: https://img.shields.io/badge/github-OCA%2Fstock--logistics--warehouse-lightgray.png?logo=github
+    :target: https://github.com/OCA/stock-logistics-warehouse/tree/16.0/stock_picking_location_check
+    :alt: OCA/stock-logistics-warehouse
+.. |badge4| image:: https://img.shields.io/badge/weblate-Translate%20me-F47D42.png
+    :target: https://translation.odoo-community.org/projects/stock-logistics-warehouse-16-0/stock-logistics-warehouse-16-0-stock_picking_location_check
+    :alt: Translate me on Weblate
+.. |badge5| image:: https://img.shields.io/badge/runboat-Try%20me-875A7B.png
+    :target: https://runboat.odoo-community.org/builds?repo=OCA/stock-logistics-warehouse&target_branch=16.0
+    :alt: Try me on Runboat
+
+|badge1| |badge2| |badge3| |badge4| |badge5|
+
+This module intends to ensure the consistency between the picking and
+its stock move lines at the time of validation.
+
+Here 'consistency' means being in the state where all the locations in
+stock move lines are the same as or under that of the corresponding
+location in the picking.
+
+**Table of contents**
+
+.. contents::
+   :local:
+
+Use Cases / Context
+===================
+
+Users sometimes change locations (location_id/location_dest_id) in the
+picking after reserving stock, and forget to update the corresponding
+locations in the detailed operations. This oversight can lead to the
+generation of stock transactions with incorrect locations.
+
+Usage
+=====
+
+An error should be displayed when validating a picking in case any of
+the locations involved in the move lines is not part of the
+corresponding location in the picking.
+
+Selecting 'Allow Location Inconsistency' lets users bypass this error.
+
+Bug Tracker
+===========
+
+Bugs are tracked on `GitHub Issues <https://github.com/OCA/stock-logistics-warehouse/issues>`_.
+In case of trouble, please check there if your issue has already been reported.
+If you spotted it first, help us to smash it by providing a detailed and welcomed
+`feedback <https://github.com/OCA/stock-logistics-warehouse/issues/new?body=module:%20stock_picking_location_check%0Aversion:%2016.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_.
+
+Do not contact contributors directly about support or help with technical issues.
+
+Credits
+=======
+
+Authors
+-------
+
+* Quartile
+
+Contributors
+------------
+
+-  `Quartile <https://www.quartile.co>`__:
+
+   -  Aung Ko Ko Lin
+   -  Yoshi Tashiro
+
+Maintainers
+-----------
+
+This module is maintained by the OCA.
+
+.. image:: https://odoo-community.org/logo.png
+   :alt: Odoo Community Association
+   :target: https://odoo-community.org
+
+OCA, or the Odoo Community Association, is a nonprofit organization whose
+mission is to support the collaborative development of Odoo features and
+promote its widespread use.
+
+This module is part of the `OCA/stock-logistics-warehouse <https://github.com/OCA/stock-logistics-warehouse/tree/16.0/stock_picking_location_check>`_ project on GitHub.
+
+You are welcome to contribute. To learn how please visit https://odoo-community.org/page/Contribute.

stock_picking_location_check/__init__.py

@@ -0,0 +1 @@
+from . import models

stock_picking_location_check/__manifest__.py

@@ -0,0 +1,17 @@
+# Copyright 2024 Quartile (https://www.quartile.co)
+# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl)
+
+{
+    "name": "Stock Picking Location Check",
+    "summary": "Ensure picking and move line locations are consistent",
+    "version": "16.0.1.0.0",
+    "author": "Quartile, Odoo Community Association (OCA)",
+    "website": "https://github.com/OCA/stock-logistics-warehouse",
+    "license": "AGPL-3",
+    "depends": ["stock"],
+    "category": "Stock",
+    "data": [
+        "views/stock_picking_views.xml",
+    ],
+    "maintainers": ["yostashiro", "aungkokolin1997"],
+}

stock_picking_location_check/i18n/ja.po

@@ -0,0 +1,40 @@
+# Translation of Odoo Server.
+# This file contains the translation of the following modules:
+# 	* stock_picking_location_check
+#
+msgid ""
+msgstr ""
+"Project-Id-Version: Odoo Server 16.0\n"
+"Report-Msgid-Bugs-To: \n"
+"POT-Creation-Date: 2024-05-20 04:25+0000\n"
+"PO-Revision-Date: 2024-05-20 04:25+0000\n"
+"Last-Translator: \n"
+"Language-Team: \n"
+"MIME-Version: 1.0\n"
+"Content-Type: text/plain; charset=UTF-8\n"
+"Content-Transfer-Encoding: \n"
+"Plural-Forms: \n"
+
+#. module: stock_picking_location_check
+#. odoo-python
+#: code:addons/stock_picking_location_check/models/stock_picking.py:0
+#, python-format
+msgid "A move line location is not related to that of the picking: %s"
+msgstr "移動明細のロケーションが運送のものと不整合です: %s"
+
+#. module: stock_picking_location_check
+#: model:ir.model.fields,field_description:stock_picking_location_check.field_stock_picking__allow_location_inconsistency
+msgid "Allow Location Inconsistency"
+msgstr "ロケーション不整合を許可"
+
+#. module: stock_picking_location_check
+#: model:ir.model.fields,help:stock_picking_location_check.field_stock_picking__allow_location_inconsistency
+msgid ""
+"If enabled, no error is raised for location inconsistency between picking "
+"and its move lines at the time of validation."
+msgstr "選択した場合、検証時に運送と移動明細で不整合があってもエラーを出しません。"
+
+#. module: stock_picking_location_check
+#: model:ir.model,name:stock_picking_location_check.model_stock_picking
+msgid "Transfer"
+msgstr "運送"

stock_picking_location_check/models/__init__.py

@@ -0,0 +1 @@
+from . import stock_picking

stock_picking_location_check/models/stock_picking.py

@@ -0,0 +1,57 @@
+# Copyright 2024 Quartile (https://www.quartile.co)
+# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl)
+
+from odoo import _, fields, models
+from odoo.exceptions import UserError
+from odoo.tools.float_utils import float_compare
+
+
+class StockPicking(models.Model):
+    _inherit = "stock.picking"
+
+    allow_location_inconsistency = fields.Boolean(
+        copy=False,
+        help="If enabled, no error is raised for location inconsistency between "
+        "picking and its move lines at the time of validation.",
+    )
+
+    def _get_child_location_ids(self, location):
+        return self.env["stock.location"].search(
+            [("id", "child_of", location.id), ("usage", "!=", "view")]
+        )
+
+    def _check_location_consistency(self, pick_location, line_locations):
+        self.ensure_one()
+        if not set(line_locations).issubset(
+            self._get_child_location_ids(pick_location)
+        ):
+            raise UserError(
+                _(
+                    "A move line location is not related to that of the picking: %s",
+                    self.name,
+                )
+            )
+
+    def _action_done(self):
+        for pick in self:
+            if pick.allow_location_inconsistency:
+                continue
+            line_source_locations = [
+                line.location_id
+                for line in pick.move_line_ids
+                if not getattr(line.move_id, "is_subcontract", False)
+            ]
+            pick._check_location_consistency(pick.location_id, line_source_locations)
+            if pick._check_immediate():
+                line_dest_locations = pick.move_line_ids.location_dest_id
+            else:
+                line_dest_locations = pick.move_line_ids.filtered(
+                    lambda line: float_compare(
+                        line.qty_done,
+                        0.0,
+                        precision_rounding=line.product_uom_id.rounding,
+                    )
+                    > 0
+                ).mapped("location_dest_id")
+            pick._check_location_consistency(pick.location_dest_id, line_dest_locations)
+        return super()._action_done()

stock_picking_location_check/readme/CONTEXT.md

@@ -0,0 +1,4 @@
+Users sometimes change locations (location_id/location_dest_id) in the picking after
+reserving stock, and forget to update the corresponding locations in the detailed
+operations. This oversight can lead to the generation of stock transactions with
+incorrect locations.

stock_picking_location_check/readme/CONTRIBUTORS.md

@@ -0,0 +1,3 @@
+- [Quartile](https://www.quartile.co):
+  - Aung Ko Ko Lin
+  - Yoshi Tashiro