[18.0][FIX] project_task_name_with_id: add active field #1773
Open
Drsmartinkus wants to merge 1 commit into
Open
[18.0][FIX] project_task_name_with_id: add active field #1773Drsmartinkus wants to merge 1 commit into
Drsmartinkus wants to merge 1 commit into
Conversation
OCA-git-bot
added
series:18.0
mod:project_task_name_with_id
AungKoKoLin1997
left a comment
AungKoKoLin1997
left a comment
Contributor
There was a problem hiding this comment.
You can add in existing xpath instead of new one.
Comment on lines
63
to
64
| <xpath expr="//field[@name='name']" position="after"> | ||
| <span class="fw-bold fs-5"> |
Contributor
There was a problem hiding this comment.
Suggested change
| <xpath expr="//field[@name='name']" position="after"> | |
| <field name="active" invisible="1" /> | |
| <span class="fw-bold fs-5"> |
…nban view The project sharing kanban view inherits the original project_sharing_project_task_view_kanban which does not include the `active` field in its arch. The inherited view references `record.active.raw_value` to toggle strikethrough on inactive tasks, but since `active` is not declared as a field in the view, the record value is undefined at render time, causing: TypeError: Cannot read properties of undefined (reading 'raw_value') Add an invisible `active` field so the value is available in the kanban record data, allowing the t-if conditional to evaluate correctly.
Drsmartinkus
force-pushed
the
18-fix-project_task_name_with_id
branch
from
July 16, 2026 06:48
7dedd22 to
8e32d85
Compare
AungKoKoLin1997
approved these changes
Jul 16, 2026
AungKoKoLin1997
left a comment
AungKoKoLin1997
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the fix.
Code Review: LG 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The project sharing kanban view inherits the original project_sharing_project_task_view_kanban which does not include the
activefield in its arch. The inherited view referencesrecord.active.raw_valueto toggle strikethrough on inactive tasks, but sinceactiveis not declared as a field in the view, the record value is undefined at render time, causing:TypeError: Cannot read properties of undefined (reading 'raw_value')Add an invisible
activefield so the value is available in the kanban record data, allowing the t-if conditional to evaluate correctly.How to reproduce this error with enterprise modules installed:
Screencast from 2026-07-16 08-01-00.webm