[19.0][MIG] project_template_milestone: Migration to 19.0#1634
[19.0][MIG] project_template_milestone: Migration to 19.0#1634Vang-NguyenPhu wants to merge 22 commits into
Conversation
This module is an addition to the project_template and project_milestone modules. It allows the milestones to be copied when a project is created from a template that contains milestones. Delete __init__.cpython-36.pyc delet project.cpython-36.pyc [UPD] Reviewer Suggestions Updated module with some reviewer suggestions and LINT fix. [UPD] Reviewer Suggestions
Fixed incorrect variable check on test.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: project-15.0/project-15.0-project_template_milestone Translate-URL: https://translation.odoo-community.org/projects/project-15-0/project-15-0-project_template_milestone/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: project-15.0/project-15.0-project_template_milestone Translate-URL: https://translation.odoo-community.org/projects/project-15-0/project-15-0-project_template_milestone/
0553add to
3242a24
Compare
alexey-pelykh
left a comment
alexey-pelykh
left a comment
There was a problem hiding this comment.
Good idea copying milestones from templates. However, tests are failing on both OCB and Odoo CI, and runboat is also red. Likely something in the project_template dependency or the milestone copy logic needs adjustment for 19.0. Happy to re-review once tests are green.
978c486 to
5f2bf09
Compare
|
Hi Mr @alexey-pelykh , I have fixed the pipeline. Please help to review again, thank you. |
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
Bot
added
the
stale
alexey-pelykh
left a comment
alexey-pelykh
left a comment
There was a problem hiding this comment.
Tests are green now — test with OCB and test with Odoo both pass, and pre-commit passes. The Detect unreleased dependencies red is just the expected check for project_template not yet being released on 19.0, not a test failure. Thanks for fixing the pipeline, @Vang-NguyenPhu.
As promised, re-reviewed the logic: the milestone copy + task re-linking works as intended, and the test verifies the 2-tasks-to-Milestone_1 / 1-task-to-Milestone_2 mapping on the generated project.
One minor, non-blocking note for future reference: the task-to-milestone re-link matches on milestone_id.name, so two milestones sharing a name within a template would collide. Fine for typical use — just worth being aware of.
LGTM.
Co-Reviewed-By: Claude Opus 4.8 noreply@anthropic.com
github-actions
Bot
removed
the
stale
11 participants
Depend on:
project_template