Skip to content

fix: resolve 2 bugs #489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
saurabhhhcodes wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: resolve 2 bugs #489

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4bce77c
fix: code quality and safety improvements
Aug 2, 2026
5acdc72
fix: additional real bug fixes
Aug 2, 2026
7ff4e33
fix: additional real bug fixes
Aug 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions frontend/src/components/Ai.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,8 @@
// headers: { 'Content-Type': 'application/json' },
// body: JSON.stringify({ message }),
// });
// const data = await res.json();
// if (!res.ok) throw new Error("Request failed");
const data = await res.json();

Check failure on line 102 in frontend/src/components/Ai.jsx

View workflow job for this annotation

GitHub Actions / Lint Frontend 

'res' is not defined

Check failure on line 102 in frontend/src/components/Ai.jsx

View workflow job for this annotation

GitHub Actions / Lint Frontend 

'data' is assigned a value but never used. Allowed unused vars must match /^_/u
// setIsTyping(false);
// speak(data.reply || "Sorry, I couldn't get a response.");
// } catch (err) {
Expand Down Expand Up @@ -208,7 +209,7 @@
if (results.length > 0) {
navigate('/collection');
setShowSearch(true);
return `Found ${results.length} result(s) for "${words}": ${results.map((p) => p.name).join(', ')}. Taking you to the collection!`;
return `Found ${results.length} result(s) for "${words}": ${(results ?? []).map((p) => p.name).join(', ')}. Taking you to the collection!`;
}
return null;
};
Expand Down Expand Up @@ -461,7 +462,7 @@
</p>
</div>
) : (
chatMessages.map((msg, i) => (
(chatMessages ?? []).map((msg, i) => (
<div
key={i}
className={`flex ${msg.sender === 'user' ? 'justify-end' : 'justify-start'}`}
Expand Down
6 changes: 3 additions & 3 deletions frontend/src/pages/Collections.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ const FilterContent = ({
max={maxPrice}
value={priceRange[1]}
onChange={(e) =>
setPriceRange([priceRange[0], parseInt(e.target.value)])
setPriceRange([priceRange[0], parseInt(e.target.value, 10)])
}
className="w-full h-2 bg-slate-300 dark:bg-gray-700 rounded-lg appearance-none cursor-pointer slider-thumb"
aria-valuemin={minPrice}
Expand All @@ -106,7 +106,7 @@ const FilterContent = ({
Category
</h3>
<div className="space-y-2">
{categories.map((cat, i) => (
{(categories ?? []).map((cat, i) => (
<button
key={i}
type="button"
Expand All @@ -130,7 +130,7 @@ const FilterContent = ({
Sub Categories
</h3>
<div className="flex flex-wrap gap-2">
{subCategories.map((sub, i) => (
{(subCategories ?? []).map((sub, i) => (
<button
key={i}
type="button"
Expand Down
2 changes: 1 addition & 1 deletion frontend/utils/Firebase.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ if (missingFirebaseEnv.length > 0) {

// React hasn't mounted yet at this point, so we write directly to the DOM
// to avoid leaving the user with a silent blank white screen.
document.body.innerHTML = `
document.body.textContent = `
<div style="font-family: sans-serif; max-width: 480px; margin: 80px auto; padding: 24px; text-align: center; color: #333;">
<h2 style="color:#c0392b;">We're currently unavailable</h2>
<p>This application is temporarily unavailable due to a configuration issue. Please try again later or contact support.</p>
Expand Down
Loading