fix(admin): prevent inventory page crash from paginated API response - #420
Closed
sujitha-kotyada wants to merge 3 commits into
Closed
fix(admin): prevent inventory page crash from paginated API response#420sujitha-kotyada wants to merge 3 commits into
sujitha-kotyada wants to merge 3 commits into
Conversation
Owner
|
@sujitha-kotyada fix the backend lint |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Summary
Fix the Admin Product Inventory page crash by correctly extracting the products array from the paginated API response.
Description
The backend
GET /api/product/listendpoint now returns a paginated response object containing bothproductsandpagination. However, the admin inventory page was storing the entire response object in theliststate, which is later treated as an array using methods such as.map()and.filter(). This caused a runtime error and prevented the inventory page from loading.Changes Made
productsarray from the API response.Array.isArray()check to ensure the component always receives an array before updating state.Testing
Related Issue
Fixes #397
Type of Change
Checklist