Skip to content

chore: remove dead code and fix useEffect dependency in UserContext#328

Open
khushboo-khatoon wants to merge 1 commit into
Nsanjayboruds:mainfrom
khushboo-khatoon:chore/remove-dead-code-fix-useeffect-dep-usercontext
Open

chore: remove dead code and fix useEffect dependency in UserContext#328
khushboo-khatoon wants to merge 1 commit into
Nsanjayboruds:mainfrom
khushboo-khatoon:chore/remove-dead-code-fix-useeffect-dep-usercontext

Conversation

@khushboo-khatoon

Copy link
Copy Markdown
Contributor

Problem

UserContext.jsx had two issues affecting code quality and correctness.


📌Issue 1 — Dead commented code left in file

Old debug/demo code was left in the catch block from previous
development/testing — never removed.

Before

} catch (error) {
  setUserData(null);
  if (error.response?.status !== 401) {
    console.error('Error fetching current user:', error);
  }
}
// catch (error) {
//   console.log('⚠ Using temporary demo user');
//   setUserData({
//     _id: "temp123",
//     name: "Demo User",
//     email: "demo@test.com",
//   });
// }

After

} catch (error) {
  setUserData(null);
  if (error.response?.status !== 401) {
    console.error('Error fetching current user:', error);
  }
}

📌Issue 2 — getCurrentUser missing from useEffect dependency array

getCurrentUser was called inside useEffect but was missing from
the dependency array, which violates React's rules of hooks and
triggers an ESLint warning.

Before

const getCurrentUser = async () => {
  try {
    const result = await apiConfig.get('/user/getCurrentUser', {
      skipAuthRedirect: true,
      skipGlobalErrorToast: true,
    });
    setUserData(result.data);
  } catch (error) {
    setUserData(null);
    if (error.response?.status !== 401) {
      console.error('Error fetching current user:', error);
    }
  }
};

useEffect(() => {
  getCurrentUser();
}, []);

After

const getCurrentUser = useCallback(async () => {
  try {
    const result = await apiConfig.get('/user/getCurrentUser', {
      skipAuthRedirect: true,
      skipGlobalErrorToast: true,
    });
    setUserData(result.data);
  } catch (error) {
    setUserData(null);
    if (error.response?.status !== 401) {
      console.error('Error fetching current user:', error);
    }
  }
}, []);

useEffect(() => {
  getCurrentUser();
}, [getCurrentUser]);

Files changed

  • UserContext.jsx

Type of Change

  • Refactoring
  • chore

Checklist

  • Code follows project guidelines
  • Tested locally
  • No console errors
  • Documentation updated if required

Closes #321

@khushboo-khatoon

Copy link
Copy Markdown
Contributor Author

hey @Nsanjayboruds ,

PR is now ready to review and merge , please lemme know if any changes needed .

thank u : )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore: remove dead commented code and fix missing useEffect dependency in UserContext.jsx

1 participant