chore: remove dead code and fix useEffect dependency in UserContext#328
Open
khushboo-khatoon wants to merge 1 commit into
Conversation
Contributor
Author
|
hey @Nsanjayboruds , PR is now ready to review and merge , please lemme know if any changes needed . thank u : ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
UserContext.jsxhad two issues affecting code quality and correctness.📌Issue 1 — Dead commented code left in file
Old debug/demo code was left in the catch block from previous
development/testing — never removed.
Before
After
📌Issue 2 — getCurrentUser missing from useEffect dependency array
getCurrentUserwas called insideuseEffectbut was missing fromthe dependency array, which violates React's rules of hooks and
triggers an ESLint warning.
Before
After
Files changed
UserContext.jsxType of Change
Checklist
Closes #321