Fix signup OTP flow and Not Found redirect on privacy links#327
Open
Honey-pg wants to merge 1 commit into
Open
Fix signup OTP flow and Not Found redirect on privacy links#327Honey-pg wants to merge 1 commit into
Honey-pg wants to merge 1 commit into
Conversation
Add privacy route redirect, axios timeout, signup error handling, SMTP timeouts, email env validation, and SPA fallback for Render.
Owner
|
@Honey-pg please slove the conflit and provide screenrecording of your change |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Summary
Fix the signup OTP flow by resolving broken privacy routes that caused 404 redirects, preventing indefinite "Sending OTP..." loading, and hardening backend email delivery with clearer errors.
Description
Users reported that signup stayed on "Sending OTP..." for a long time and then redirected to a Not Found page. Several issues contributed:
Changes made:
frontend/src/App.jsx— Added/privacy→/privacypolicyredirectfrontend/src/pages/Registration.jsx— Fixed Privacy Policy link, added inlinesubmitError, aligned name validation to min 3 chars, addedskipAuthRedirecton OTP API callsfrontend/src/pages/LandingPage.jsx— Updated footer Privacy links to/privacypolicyfrontend/src/utils/apiConfig.js— Added 30s axios timeout to stop infinite loadingfrontend/public/_redirects— Added SPA fallback for Render deep links like/signupbackend/config/sendEmail.js— Added SMTP timeouts and startup warning when email env vars are missingbackend/controller/authcontroller.js— Returns503fast if email service is not configuredbackend/.env.example— DocumentedEMAIL_USERandEMAIL_PASSWhy:
/privacyhad no route, sending users to the 404 page during signup/signuploads correctly after refresh on RenderRelated Issue
Fixes #311
Type of Change
Checklist