vgd-probe multi-mode args + phase-5 lifecycle milestone notes#11
Merged
Conversation
…ilestone parse_args kept a single Option<ModeSpec>, so "3456x2160@240 3456x2160@120" silently dropped every mode but the last and the multi-mode create path was untestable standalone. Collect all WxH@HZ arguments instead (default list unchanged when none given). CLAUDE.md: phase-5 lifecycle milestone verified — Moonlight streams off the virtual display via LuminalShine's luminalvgd backend (exclusive topology, 240 Hz multi-mode, clean restore). Records the host-side integration lessons (NBF-aware resolvers, millihertz units, SDR-until- HDR10) and scopes tranche 3b. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WxH@HZmode arguments (previously only the last one survived, silently), making multi-mode CREATE_MONITOR testable standalone — this was the tool gap that initially masked LuminalShine's millihertz double-scaling bug.luminalvgdbackend (exclusive topology, 240 Hz multi-mode applied first-try, clean restore of physical monitors) — plus the host-side integration lessons (NBF-aware resolvers, mHz units, SDR-until-HDR10) and tranche 3b scope.Verification
cargo test --workspace: 91 passed, 0 failed.3456x2160@240 3456x2160@120 --ephemeralregisters both modes in Windows (EnumDisplaySettings) and runs at 240 Hz preferred.🤖 Generated with Claude Code