refactor: unify android runtime c++ layout

[DjDeveloperr]

Summary

• keep the imported Android Java/project sources under platforms/android, while sharing Android C++ through NativeScript/runtime/android, NativeScript/napi/android, and NativeScript/ffi/jni/napi
• keep Apple FFI under NativeScript/ffi/objc and update generated-output/test wiring for the unified layout
• collapse Android HERMES and SHERMES onto the same Static Hermes (shermes) header/library surface already used by Apple; SHERMES remains only a compatibility engine selector
• remove the earlier Android engine-specific runtime test gates so Android test assets stay at imported upstream parity
• harden JNI Node-API constructor/object fallback behavior for Static Hermes and preserve ObjC bridge ownership/expandos across Apple engines
• keep iOS/macOS direct engines unchanged in scope; Android-only engines were probed on Apple and remain unwired/unsupported for this PR

Commit Review Order

1. Layout moves and Android build wiring:
   • b16346f1 refactor: move objc ffi under platform namespace
   • 055964e5 refactor: move android jni napi ffi into shared tree
   • a0a2ed87 refactor: move android runtime sources into shared tree
   • 8d214e29 refactor: move android napi engines into shared tree
   • 04c486be refactor: wire android build to unified runtime layout
2. Behavior preservation and cleanup after the move:
   • 3aab3c3b fix(apple): update objc ffi generated paths
   • 4def1b90 fix(android): align hermes napi adapters
   • 86dec82f fix(android): preserve unified runtime behavior
   • da00c3af fix(android): stabilize runtime test harness
   • 6bff08ee fix: clean up runtime refactor paths
3. Static Hermes unification:
   • 15d7c2a4 refactor(android): unify static hermes backend
4. Final review/test fixes:
   • 98918758 fix(jni): handle static hermes constructor receivers
   • 5bc35047 fix(objc): preserve bridge object ownership
   • 1668c885 fix(quickjs): clear weak refs before forced gc
   • 6ba820c1 test(ios): skip app main in scripted runner
   • a0e09674 revert(android): restore runtime test parity
   • 1dae9f74 fix(android): clear quickjs weak refs before gc
   • 6d556df7 chore(android): refresh native vscode paths

Note: fd62fdb5 added Android engine-specific runtime test gates during review, and is intentionally reverted by a0e09674. Review the net effect after the revert.

Validation

• Latest cleanup checks after reverting the Android test gates:
  • git diff --check
  • npm run check:ffi-boundaries
  • ./gradlew ':runtime:buildCMakeDebug[x86]' -Pengine=QUICKJS_NG -PonlyX86: :runtime:buildCMakeDebug[x86] completed; the Gradle invocation then failed in the :app:buildMetadata finalizer path under local JDK 25 (:android-metadata-generator:compileKotlin rejects 25.0.2, and :dts-generator:compileJava fails on existing -Werror warnings)
  • ./gradlew ':runtime:buildCMakeDebug[x86]' -Pengine=QUICKJS -PonlyX86: :runtime:buildCMakeDebug[x86] and :runtime:buildCMakeRelWithDebInfo[x86] completed; same unrelated metadata finalizer failures under JDK 25
• Earlier full Android all-engine matrix before the final fd62fdb5 revert, Pixel_9_Pro_API_36 emulator, JDK 17, logs in /tmp/ns-runtime-android-engine-matrix-final-20260608-235950:
  • V8-10: 443 specs, 0 failures, 12 skipped, 16 disabled
  • V8-11: 443 specs, 0 failures, 12 skipped, 16 disabled
  • V8-13: 443 specs, 0 failures, 12 skipped, 16 disabled
  • QUICKJS: 443 specs, 0 failures, 12 skipped, 16 disabled
  • QUICKJS_NG: 443 specs, 0 failures, 12 skipped, 16 disabled
  • PRIMJS: 443 specs, 0 failures, 12 skipped, 16 disabled on rerun; initial run hit one TNS Workers > Should keep the worker alive after error timeout, logs in /tmp/ns-runtime-android-primjs-rerun-20260609-001236
  • JSC: 442 specs, 0 failures, 36 skipped, 46 disabled
  • HERMES: 442 specs, 0 failures, 52 skipped, 43 disabled
  • SHERMES: 442 specs, 0 failures, 52 skipped, 43 disabled
• Android parity spot-checks against standalone NativeScript/napi-android:
  • V8-10: 443 specs, 0 failures, 12 skipped, 16 disabled
  • PRIMJS: 443 specs, 0 failures, 12 skipped, 16 disabled
  • removing the PR's engine-specific worker gates makes both this branch and standalone napi-android JSC crash at TNS Workers > Should throw exception when no parameter is passed with NativeScriptException, with no XML result; parity logs in /tmp/ns-runtime-no-fd62-android-matrix-20260609-002813 and /tmp/napi-android-standalone-jsc-parity-20260609-003053
• iOS simulator direct-engine matrix, logs in /tmp/ns-runtime-apple-matrix-final7:
  • v8: 713 specs, 0 failures, 13 skipped
  • hermes: 713 specs, 0 failures, 11 skipped
  • quickjs: 713 specs, 0 failures, 13 skipped
  • jsc: 713 specs, 0 failures, 13 skipped
• macOS direct-engine matrix, logs in /tmp/ns-runtime-apple-matrix-final7:
  • v8: 713 specs, 0 failures, 10 skipped
  • hermes: 713 specs, 0 failures, 8 skipped
  • quickjs: 713 specs, 0 failures, 10 skipped
  • jsc: 713 specs, 0 failures, 10 skipped
• Android-only engine probe on Apple CMake: primjs, quickjs_ng, v8-10, v8-11, and v8-13 are still unsupported/unwired on Apple in this PR
• Earlier hygiene checks:
  • python3 -m py_compile metadata-generator/build-step-metadata-generator.py
  • stale-path/debug sweeps for removed Hermes/fbjni paths and temporary ObjC debug prints

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: fee71fa9-25cf-48a8-8d9f-a3103ccba740

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch codex/plan-android-cpp-refactor

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}