rename Cloudflare Pages project to meridian-orderbook - #22
Merged
Conversation
The originally planned project name `meridian-demo` is already taken on the Cloudflare Pages global namespace by an unrelated project (a curl against `meridian-demo.pages.dev` returns a third-party page, not ours), so a fresh checkout of the deploy artifacts would have hit a name collision on the first `pnpm wrangler pages project create`. Swap every reference to `meridian-demo` -> `meridian-orderbook`. The new name is specific (it pairs with the engine half of the deploy as "meridian-engine on Fly, meridian-orderbook on Pages"), descriptive, and currently free on the Pages namespace. Files touched: * `fly.toml`: `MERIDIAN_ORIGINS` baked allowlist. * `.github/workflows/deploy.yml`: `cloudflare/pages-action` project name. * `frontend/.env.production` (already had no demo string; left alone). * `README.md` live demo section. * `docs/adr/0004-cloudflare-pages-and-fly-io.md`, `docs/architecture.md`, `docs/security/threat-model.md`, `docs/security/checklist.md`, `docs/security/secrets.md`, `docs/setup-guide.md`, `docs/qa/regression-checklist.md`: every textual reference. * `apps/server/main.cpp` CLI help text example. * `include/meridian/ws_server.hpp` doc comment example. * `tests/unit/test_ws_origin.cpp` `kAllowedOrigin` constant. 182/182 C++ tests and 15/15 frontend tests still pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The originally planned project name
meridian-demois already taken on the Cloudflare Pages global namespace by an unrelated project. Runningcurl https://meridian-demo.pages.dev/returns a third-party page, not ours, so a fresh checkout of the deploy artifacts from PR #21 would have hit a name collision on the firstwrangler pages project create.Swap every textual reference of
meridian-demotomeridian-orderbook. The new name was probed (curl https://meridian-orderbook.pages.dev/fails to resolve) and is plausibly free.Files touched (13, +27 / -27 lines, purely textual)
fly.toml:MERIDIAN_ORIGINSbaked allowlist..github/workflows/deploy.yml:cloudflare/pages-actionproject name input.README.mdlive demo section.docs/adr/0004-cloudflare-pages-and-fly-io.md,docs/architecture.md,docs/security/threat-model.md,docs/security/checklist.md,docs/security/secrets.md,docs/setup-guide.md,docs/qa/regression-checklist.md: every reference.apps/server/main.cppCLI help text example.include/meridian/ws_server.hppdoc comment example.tests/unit/test_ws_origin.cppkAllowedOriginconstant.Verification
ctest --test-dir build-release182/182cd frontend && pnpm test15/15pnpm run buildclean; production bundle still bakeswss://meridian-engine.fly.dev/ws