Drop unused camera-view dependency and fix gradle.properties trailing newline#28
Conversation
… newline Remove the androidx.camera:camera-view:1.4.2 implementation dependency. The app uses CameraX only for headless frame analysis (ImageAnalysis, ImageProxy, CameraSelector from camera-core and ProcessCameraProvider from camera-lifecycle); it never instantiates a PreviewView or CameraController, so the camera-view UI layer was dead weight pulled into the build. Source has zero androidx.camera.view references. Also add the missing trailing newline to gradle.properties. Debug build succeeds and the full unit test suite stays green at 483 passing, 0 failures, 4 skipped, identical to the pre-change baseline.
Code Reviewer verdict: APPROVEDIndependently verified against the source tree, not taken on the PR description's word. camera-view removal is safe. Grep of Required-to-stay dependencies confirmed present. Build and tests. No inherited-rule concerns (config-only diff, no prose added). No new dependency, so no Security sign-off triggered. Ready to merge. |
Summary
Two small build cleanups flagged by the Code Reviewer on PR #26 and PR #27, batched into one PR. No production behavior change.
androidx.camera:camera-view:1.4.2. CameraX is used only for headless frame analysis in the vision test (ImageAnalysis,ImageProxy,CameraSelectorfromcamera-core;ProcessCameraProviderfromcamera-lifecycle). The app never instantiates aPreviewVieworCameraController, so thecamera-viewUI artifact was pulled into the build for nothing. A source-wide search confirms zeroandroidx.camera.view,PreviewView,CameraController, orLifecycleCameraControllerreferences.gradle.properties(cosmetic nit from the PR Target Android 15 (API 35) for Play upload #26 review).Verification
:app:assembleDebugsucceeds.mainbaseline, confirming the dependency removal regressed nothing.Permissions
No change. The manifest still declares CAMERA and RECORD_AUDIO only.