fix: bug on partial and ent_type precision/recall when merging multi-documents#109
Merged
Merged
Conversation
… results _merge_results() was calling compute_metrics() with no arguments after merging counts, so partial_or_type defaulted to False and strict formula (COR/ACT, COR/POS) was used for all strategies. That overwrote the correct partial/ent_type P/R (COR+0.5*PAR)/ACT and (COR+0.5*PAR)/POS. Now pass strategy_name into _merge_results and call compute_metrics(partial_or_type=True) for 'partial' and 'ent_type' so merged results keep the SemEval partial-match formula. Fixes the bug where partial (and ent_type) reported same P/R as strict (e.g. README example showed 0.40 instead of 0.70 for partial). Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes:
compute_metrics(partial_or_type=True)in_merge_resultsfor those strategies.How did you test it?
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:and added!in case the PR includes breaking changes.