Use proposed ImageLoader API to pick optimal compression format.#2
Open
castano wants to merge 1 commit into
Open
Use proposed ImageLoader API to pick optimal compression format.#2castano wants to merge 1 commit into
castano wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR modifies the SparkGltfastAddon to use a new
ITextureImageLoaderAPI in glTFast that allows us to choose the optimal compression format.This requires the following PRs to be merged in glTFast:
Currently the code is referencing a local package with the changes above, but that should be removed before merging.