Skip to content

Handle alternate CLI entry points when saving checkpoints - #2318

Open
Marchematics wants to merge 1 commit into
Lightning-AI:mainfrom
Marchematics:fix/save-hyperparameters-entrypoint
Open

Handle alternate CLI entry points when saving checkpoints#2318
Marchematics wants to merge 1 commit into
Lightning-AI:mainfrom
Marchematics:fix/save-hyperparameters-entrypoint

Conversation

@Marchematics

Copy link
Copy Markdown

Fixes #1102

save_hyperparameters now strips both current and legacy nested LitGPT command forms before parsing checkpoint arguments. When called through an unrelated wrapper, it skips capture instead of aborting checkpoint saving.

Tests: pytest tests/test_utils.py -q -k save_hyperparameters (11 passed).

Ruff checks pass.

Copilot AI lite review requested due to automatic review settings August 31, 2026 15:06

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make save_hyperparameters() robust against different CLI entry points

2 participants