feat: support local auth - #7
Merged
Merged
Conversation
|
The author of this PR, k223kim, is not an activated member of this organization on Codecov. |
k223kim
marked this pull request as ready for review
July 24, 2025 01:25
k223kim
requested review from
Abdul-0x4A,
Borda,
Danidapena,
aniketmaurya and
tchaton
as code owners
July 24, 2025 01:25
aniketmaurya
approved these changes
Jul 24, 2025
aniketmaurya
left a comment
Collaborator
There was a problem hiding this comment.
Looks good 🚀
Maybe we should be passing the lightning_api_key all the way where it is required rather than relying on env variable? (for a follow up of course)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before submitting
What does this PR do?
Non-studio users can use LitAI. The difference to this approach is the following:
lightning_api_keyandlightning_user_idare given, no further authPR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃