Skip to content

feat: support local auth - #7

Merged
aniketmaurya merged 1 commit into
mainfrom
k223kim/add-local-auth
Jul 24, 2025
Merged

feat: support local auth#7
aniketmaurya merged 1 commit into
mainfrom
k223kim/add-local-auth

Conversation

@k223kim

@k223kim k223kim commented Jul 24, 2025

Copy link
Copy Markdown
Collaborator
Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

Non-studio users can use LitAI. The difference to this approach is the following:

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@codecov

codecov Bot commented Jul 24, 2025

Copy link
Copy Markdown

The author of this PR, k223kim, is not an activated member of this organization on Codecov.
Please activate this user on Codecov to display this PR comment.
Coverage data is still being uploaded to Codecov.io for purposes of overall coverage calculations.
Please don't hesitate to email us at support@codecov.io with any questions.

@k223kim
k223kim marked this pull request as ready for review July 24, 2025 01:25

@aniketmaurya aniketmaurya left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 🚀

Maybe we should be passing the lightning_api_key all the way where it is required rather than relying on env variable? (for a follow up of course)

@aniketmaurya
aniketmaurya merged commit ed2bb48 into main Jul 24, 2025
31 checks passed
@aniketmaurya
aniketmaurya deleted the k223kim/add-local-auth branch July 24, 2025 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants