Skip to content

fix: add KMS key ARNs for secret decryption in midaz configuration - #25

Merged
guimoreirar merged 1 commit into
mainfrom
fix/elasticache-secret-string
Mar 25, 2026
Merged

fix: add KMS key ARNs for secret decryption in midaz configuration#25
guimoreirar merged 1 commit into
mainfrom
fix/elasticache-secret-string

Conversation

@guimoreirar

Copy link
Copy Markdown
Member
  • Introduced RDS, DocumentDB, and AmazonMQ KMS Key ARNs in application.yaml, full-stack.yaml, and helm.yaml to facilitate secure secret decryption.
  • Updated infrastructure.yaml and respective templates to export KMS Key ARNs for proper resource management and access control.

- Introduced RDS, DocumentDB, and AmazonMQ KMS Key ARNs in application.yaml, full-stack.yaml, and helm.yaml to facilitate secure secret decryption.
- Updated infrastructure.yaml and respective templates to export KMS Key ARNs for proper resource management and access control.
@guimoreirar guimoreirar self-assigned this Mar 25, 2026
@coderabbitai

coderabbitai Bot commented Mar 25, 2026

Copy link
Copy Markdown

Caution

Review failed

Pull request was closed or merged during review

Walkthrough

This change adds infrastructure support for exposing KMS key ARNs through a CloudFormation stack hierarchy. Six template files are updated to surface KMS key identifiers from RDS, DocumentDB, and AmazonMQ nested stacks, thread them through intermediate stacks, and pass them to Helm deployments. An IAM policy for the Helm deployer role is also refined to reference these explicit KMS key ARNs instead of a broader wildcard pattern combined with a service endpoint condition.

🚥 Pre-merge checks | ✅ 2
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main change: adding KMS key ARNs for secret decryption in midaz configuration files.
Description check ✅ Passed The description is directly related to the changeset, detailing the introduction of KMS Key ARNs across configuration files for secret decryption.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Comment @coderabbitai help to get the list of available commands and usage tips.

@lerian-studio

Copy link
Copy Markdown

Consider updating CHANGELOG.md to document this change. If this change doesn't need a changelog entry, add the skip-changelog label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants