feat: add KMS decryption permissions to midaz helm configuration - #24
Conversation
guimoreirar
commented
Mar 25, 2026
- Included a new IAM policy allowing KMS decryption for resources in the midaz helm.yaml, ensuring secure access to secrets managed by AWS Secrets Manager.
- Included a new IAM policy allowing KMS decryption for resources in the midaz helm.yaml, ensuring secure access to secrets managed by AWS Secrets Manager.
WalkthroughAn IAM policy statement was added to the 🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
|
Consider updating CHANGELOG.md to document this change. If this change doesn't need a changelog entry, add the |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@products/midaz/helm.yaml`:
- Around line 171-177: Replace the overly-broad KMS resource "key/*" with
explicit ARNs by adding new CloudFormation parameters (e.g., RDSKMSKeyArn,
DocumentDBKMSKeyArn, AmazonMQKMSKeyArn) and then update the IAM policy block
(the statement that currently has Action: kms:Decrypt and Resource: !Sub
"arn:aws:kms:${AWS::Region}:${AWS::AccountId}:key/*") to reference only those
specific ARN parameters (or a list of the specific key ARNs used by your
secrets) so kms:Decrypt is limited to the RDSKMSKey / DocumentDBKMSKey /
AmazonMQKMSKey resources rather than all keys.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: f348348e-e03d-4232-a7b5-cfa5caeab1d9
📒 Files selected for processing (1)
products/midaz/helm.yaml