Added Docker and Vagrant support#32
Open
Manouchehri wants to merge 2 commits into
Open
Conversation
Lekensteyn
reviewed
Dec 1, 2017
| pip install pyusb && \ | ||
| su - lglaf -c "git clone https://github.com/Lekensteyn/lglaf.git" && \ | ||
| cp -v ~/lglaf/rules.d/42-usb-lglaf.rules /etc/udev/rules.d/ && \ | ||
| udevadm control --reload-rules || true && \ |
Owner
There was a problem hiding this comment.
this || true looks wrong.
Since you have an isolated container anyway, you could also consider a chgrp lglaf /dev/usb/*/* I guess.
Author
There was a problem hiding this comment.
That's just so Dockerhub doesn't bail out on building.
Won't that break hotplugging?
Owner
There was a problem hiding this comment.
I hoped that inotify works also in Docker containers, then you do not need any udevadm command. If you can do hotplugging, try checking for events with udevadm monitor while your container has started.
Author
There was a problem hiding this comment.
udevadm monitor sees the kernel plug events, but doesn't apply udev rules. udev seems to refuse since it detects that it's a container.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Example usage: