fix unwanted CRLF conversion on windows#11
Open
erik-smit wants to merge 1 commit into
Open
Conversation
ehem
reviewed
Dec 31, 2016
There was a problem hiding this comment.
Ick! Alas, looking at documentation I can see why you want to do this. :-(
First, any additions should be moved to the except clause. Using sys.stdout.buffer takes care of this in a portable way for Python 3, so something like this is only needed if the try fails (indicating Python 2).
Does:
stdout_bin = os.fdopen(os.dup(1), "wb")
in the except clause get you binary output with Python 2 on Windows? When looking for alternatives I read os.fdopen(1, "wb") doesn't work, but perhaps this is sufficient to not get optimized out by Python 2.
Owner
|
@erik-smit Thanks for your PR! Does this also work with Python 3? Can you try the suggestion from @ehem? |
Author
|
I don't really have time to further this, sorry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
python 2.x does CRLF conversion on windows by default, causing my READs to be damaged.
Took my fix from http://stackoverflow.com/questions/2374427/python-2-x-write-binary-output-to-stdout