Skip to content

stop allocating an applyIf by default#56

Open
Alexdoru wants to merge 1 commit into
LegacyModdingMC:masterfrom
Alexdoru:applyif-alloc
Open

stop allocating an applyIf by default#56
Alexdoru wants to merge 1 commit into
LegacyModdingMC:masterfrom
Alexdoru:applyif-alloc

Conversation

@Alexdoru

Copy link
Copy Markdown
Contributor

small pr to remove the allocation of the applyif

@Alexdoru Alexdoru marked this pull request as ready for review July 20, 2025 10:55
@ah-OOG-ah

Copy link
Copy Markdown
Member

is there a reason this should be removed? this allocation shouldn't be causing any issues.
(plus, doesn't that get converted to a single shared object for all instances, since it doesn't capture anything?)

@Alexdoru

Copy link
Copy Markdown
Contributor Author

is there a reason this should be removed? this allocation shouldn't be causing any issues. (plus, doesn't that get converted to a single shared object for all instances, since it doesn't capture anything?)

it's totally unnecessary it just makes all the fields in that class nonnull I like it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants