test(e2e): harmonize LWD and LWM test names in Allure (QAA-1434) - #20273
Open
VicAlbr wants to merge 5 commits into
Open
test(e2e): harmonize LWD and LWM test names in Allure (QAA-1434)#20273VicAlbr wants to merge 5 commits into
VicAlbr wants to merge 5 commits into
Conversation
Contributor
Web Tools Build Status
|
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request standardizes E2E test and suite naming across Ledger Wallet Desktop (LWD) and Ledger Wallet Mobile (LWM) to make Allure reports easier to compare cross-platform, and introduces a shared Currency.testLabel helper to avoid title collisions for tickers reused across multiple networks/tokens.
Changes:
- Harmonize
describeand test titles across Desktop (Playwright) and Mobile suites to follow a consistent Allure-friendly naming convention. - Add
Currency.testLabelto centralize “unique ticker label” logic (e.g.,ETH (Base),USDT (Ethereum)), preventing duplicate-title collisions. - Small Allure metadata fixes while renaming (e.g., adding missing
teamOwner, ensuring TMS links render where expected).
Reviewed changes
Copilot reviewed 96 out of 96 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| libs/live-e2e-shared/src/enum/Currency.ts | Adds testLabel getter and central label map to keep test titles unique. |
| e2e/mobile/specs/wallet40Q2/walletAssets.spec.ts | Renames Wallet 4.0 assets suite/tests to the new convention using testLabel. |
| e2e/mobile/specs/wallet40Q2/portfolio.spec.ts | Renames Portfolio suite/tests; introduces testLabel usage in relevant titles. |
| e2e/mobile/specs/wallet40Q2/operationsHistory.spec.ts | Renames Operations History suite/tests for consistent Allure grouping. |
| e2e/mobile/specs/wallet40Q2/myWallet.spec.ts | Renames My Wallet suite/tests for consistent Allure grouping. |
| e2e/mobile/specs/wallet40Q2/mainNavigation.spec.ts | Renames navigation suite/tests to align naming across platforms. |
| e2e/mobile/specs/wallet40Q2/assetDiscoverability.spec.ts | Renames asset discoverability suites/tests and adopts testLabel where applicable. |
| e2e/mobile/specs/wallet40Q2/assetAggregationMarketDetail.spec.ts | Renames aggregation/market/detail tests and adds testLabel prefixes. |
| e2e/mobile/specs/verifyAddress/verifyEmptyAddressTRX.spec.ts | Renames receive/verify-address test to the standardized format with testLabel. |
| e2e/mobile/specs/verifyAddress/verifyAddressWarning.ts | Renames verify-address warning runner suite/test to standardized Receive naming. |
| e2e/mobile/specs/verifyAddress/verifyAddress.ts | Renames verify-address runner suite/test to standardized Receive naming. |
| e2e/mobile/specs/verifyAddress/receiveFlow.spec.ts | Renames Receive flow suite/tests for consistent Allure naming. |
| e2e/mobile/specs/userOpensApplication.spec.ts | Renames suite/test title for standardized reporting (suite naming flagged in review). |
| e2e/mobile/specs/swap/tokenApprovalFlow/swapTokenReapprovalFlow.ts | Renames swap reapproval suite/test titles and adds pair-based testLabel prefix. |
| e2e/mobile/specs/swap/tokenApprovalFlow/swapTokenApprovalFlow.ts | Renames swap approval suite/test titles and adds pair-based testLabel prefix. |
| e2e/mobile/specs/swap/swap.ts | Renames “Swap accepted” suite and swaps test title to [FROM-TO] - …. |
| e2e/mobile/specs/swap/otherTestCases/swapDexNativeFlow.ts | Renames DEX native flow suite/test titles using testLabel and provider name. |
| e2e/mobile/specs/swap/otherTestCases/swapDeeplinks.spec.ts | Renames swap deeplinks suite and scenario names for readability. |
| e2e/mobile/specs/swap/otherTestCases/swap.other.ts | Renames multiple swap suites/tests (history, send max, entry points, errors) to match convention. |
| e2e/mobile/specs/swap/otherTestCases/swap.crossAccount.ts | Renames cross-account warning suite/test and adds [FROM-TO] prefix. |
| e2e/mobile/specs/swap/otherTestCases/swap_noAccountTo.spec.ts | Updates scenario title to the standardized phrasing. |
| e2e/mobile/specs/swap/otherTestCases/swap_noAccountFromAndTo.spec.ts | Updates scenario title to the standardized phrasing. |
| e2e/mobile/specs/swap/otherTestCases/swap_noAccountFrom.spec.ts | Updates scenario title to the standardized phrasing. |
| e2e/mobile/specs/subAccount/subAccount.ts | Renames sub-account and token send suites/tests; adopts testLabel in titles. |
| e2e/mobile/specs/stake/stake.ts | Renames Tezos staking suites/tests and adopts testLabel prefixes. |
| e2e/mobile/specs/settings/settings.ts | Consolidates settings-related suite naming and standardizes test titles. |
| e2e/mobile/specs/send/sendValidAddress/sendValidAddressXRP.spec.ts | Standardizes “with tag” naming for send valid-address case. |
| e2e/mobile/specs/send/sendValidAddress/sendValidAddressETH3.spec.ts | Standardizes “lower case address” naming for send valid-address case. |
| e2e/mobile/specs/send/sendValidAddress/sendValidAddressETH2.spec.ts | Standardizes “existing account” naming and formatting for send valid-address case. |
| e2e/mobile/specs/send/sendValidAddress/sendValidAddressETH_USDT.spec.ts | Standardizes “recipient and amount” naming for send valid-address case. |
| e2e/mobile/specs/send/sendValidAddress/sendValidAddressBTC_TAPROOT.spec.ts | Standardizes “taproot” naming for send valid-address case. |
| e2e/mobile/specs/send/sendValidAddress/sendValidAddressBTC_SEGWIT.spec.ts | Standardizes “segwit” naming for send valid-address case. |
| e2e/mobile/specs/send/sendValidAddress/sendValidAddressBTC_NATIVE_SEGWIT.spec.ts | Standardizes “native segwit” naming for send valid-address case. |
| e2e/mobile/specs/send/sendValidAddress/sendValidAddressBTC_LEGACY.spec.ts | Standardizes “legacy” naming for send valid-address case. |
| e2e/mobile/specs/send/sendValidAddress/sendValidAddressBCH.spec.ts | Standardizes “cash address” naming for send valid-address case. |
| e2e/mobile/specs/send/sendValidAddress/sendValidAddressATOM2.spec.ts | Standardizes “without tag” naming for send valid-address case. |
| e2e/mobile/specs/send/sendValidAddress/sendValidAddressATOM.spec.ts | Standardizes “with tag” naming for send valid-address case. |
| e2e/mobile/specs/send/send.ts | Renames send suites/tests (valid/invalid address, invalid amount, max, ENS) using testLabel. |
| e2e/mobile/specs/send/newSendFlow.ts | Renames new send flow suite/test to standardized naming. |
| e2e/mobile/specs/portfolio/portfolioTabs.spec.ts | Renames portfolio tabs suite/tests to standardized titles. |
| e2e/mobile/specs/portfolio/portfolio.ts | Standardizes Portfolio suite and test naming; adopts testLabel where relevant. |
| e2e/mobile/specs/marketBanner.spec.ts | Renames Market banner suite/test and adds testLabel prefix. |
| e2e/mobile/specs/market.spec.ts | Renames Market suite/test and adds testLabel prefix. |
| e2e/mobile/specs/ledgerSync/ledgerSync.spec.ts | Renames Ledger Sync suite/test to standardized naming. |
| e2e/mobile/specs/languageChange.spec.ts | Moves language change under Settings suite naming and standardizes test titles. |
| e2e/mobile/specs/earn/earnV2.ts | Standardizes Earn v2 suite/test naming and adds testLabel prefixes. |
| e2e/mobile/specs/deposit/deposit.ts | Standardizes Deposit suite/test naming with testLabel and scenario details. |
| e2e/mobile/specs/deleteAccount/deleteAccount.ts | Standardizes delete account test title with testLabel. |
| e2e/mobile/specs/delegate/delegateSEI.spec.ts | Standardizes SEI delegation test title with testLabel. |
| e2e/mobile/specs/delegate/delegate.ts | Standardizes delegation/lock/vote suite/test naming and adds testLabel prefixes. |
| e2e/mobile/specs/deeplinks.spec.ts | Renames Deeplinks suite/test titles and adjusts nested suite naming (nested suite naming flagged in review). |
| e2e/mobile/specs/buySell/buySell.ts | Standardizes Buy/Sell suite/test names with testLabel. |
| e2e/mobile/specs/addAccount/addAccountALEO.spec.ts | Standardizes Add account suite/test name with testLabel. |
| e2e/mobile/specs/addAccount/addAccount.ts | Standardizes Add account suite/test naming with testLabel. |
| e2e/mobile/specs/account/accountRename.spec.ts | Standardizes rename account suite/test naming with testLabel. |
| e2e/desktop/tests/utils/newSendFlowUtils.ts | Standardizes desktop “new send flow” grouping and test titles using testLabel. |
| e2e/desktop/tests/specs/validation.swap.spec.ts | Standardizes swap validation suite/test names with testLabel pair prefixes. |
| e2e/desktop/tests/specs/undelegate.spec.ts | Standardizes undelegate suite/test naming with testLabel. |
| e2e/desktop/tests/specs/ui.swap.spec.ts | Adds missing teamOwner and renames swap UI test with testLabel pair prefix. |
| e2e/desktop/tests/specs/token.reapproval.swap.spec.ts | Standardizes token reapproval suite/test naming with testLabel pair prefix. |
| e2e/desktop/tests/specs/token.approval.swap.spec.ts | Standardizes token approval suite/test naming with testLabel pair prefix. |
| e2e/desktop/tests/specs/subAccount.spec.ts | Standardizes sub-account and token send suite/test naming with testLabel. |
| e2e/desktop/tests/specs/stake.spec.ts | Standardizes Tezos staking suite/test naming with testLabel. |
| e2e/desktop/tests/specs/settings.spec.ts | Standardizes Settings suite/test naming with testLabel where relevant. |
| e2e/desktop/tests/specs/send.tx.spec.ts | Standardizes send test grouping and titles; introduces testName for clearer case labels. |
| e2e/desktop/tests/specs/send.swap.spec.ts | Standardizes “Swap accepted” suite/test naming with [FROM-TO] prefix. |
| e2e/desktop/tests/specs/rename.account.spec.ts | Standardizes rename account suite/test naming with testLabel. |
| e2e/desktop/tests/specs/receive.address.spec.ts | Standardizes Receive suite/test naming with testLabel. |
| e2e/desktop/tests/specs/quickAmount.swap.spec.ts | Standardizes swap quick-amount suite/test naming (mix of multi-pair and single-pair titles). |
| e2e/desktop/tests/specs/provider.swap.spec.ts | Standardizes provider flow suite/test titles with testLabel and provider name. |
| e2e/desktop/tests/specs/portfolio.spec.ts | Standardizes Portfolio suite/test naming and ensures TMS links render in Allure. |
| e2e/desktop/tests/specs/operationsList.spec.ts | Renames Operations list suite/test to “Operations history” wording. |
| e2e/desktop/tests/specs/newSendFlowToken.tx.spec.ts | Removes redundant wrapper describe and relies on shared registration utility. |
| e2e/desktop/tests/specs/newSendFlow.tx.spec.ts | Removes redundant wrapper describes and relies on shared registration utility. |
| e2e/desktop/tests/specs/myWallet.spec.ts | Standardizes My Wallet suite naming. |
| e2e/desktop/tests/specs/marketBanner.spec.ts | Standardizes Market banner suite/test naming with testLabel. |
| e2e/desktop/tests/specs/market.spec.ts | Standardizes Market test title with testLabel pair prefix. |
| e2e/desktop/tests/specs/main.navigation.spec.ts | Standardizes Main navigation test titles. |
| e2e/desktop/tests/specs/ledgerSync.spec.ts | Standardizes Ledger Sync suite/test naming. |
| e2e/desktop/tests/specs/entrypoint.swap.spec.ts | Standardizes swap entry points and related suites/tests using testLabel. |
| e2e/desktop/tests/specs/earn.v2.spec.ts | Standardizes Earn v2 suite/test naming and sub-suite structure with testLabel. |
| e2e/desktop/tests/specs/discreet.swap.spec.ts | Standardizes discreet mode swap suite/test titles. |
| e2e/desktop/tests/specs/delete.account.spec.ts | Standardizes delete account suite/test naming with testLabel. |
| e2e/desktop/tests/specs/delegate.spec.ts | Consolidates delegation specs (incl. SEI) and standardizes titles using testLabel. |
| e2e/desktop/tests/specs/deeplink.swap.spec.ts | Standardizes Swap deeplinks suite/test and step naming. |
| e2e/desktop/tests/specs/crossAccount.warning.swap.spec.ts | Standardizes cross-account warning suite/test naming with testLabel pair prefix. |
| e2e/desktop/tests/specs/buySell.spec.ts | Standardizes Buy/Sell suite/test naming with testLabel. |
| e2e/desktop/tests/specs/borrow.spec.ts | Standardizes Borrow suite/test naming with testLabel. |
| e2e/desktop/tests/specs/assets.discoverability.spec.ts | Standardizes asset discoverability suite/test names and adopts testLabel. |
| e2e/desktop/tests/specs/assets.aggregation.spec.ts | Standardizes aggregation/detail/star/address-detail suite/test naming with testLabel. |
| e2e/desktop/tests/specs/assets.addresses.spec.ts | Standardizes wallet assets suite/test naming with testLabel. |
| e2e/desktop/tests/specs/add.account.spec.ts | Standardizes Add account suite/test naming with testLabel. |
| e2e/desktop/tests/specs/activate.private.balance.spec.ts | Standardizes “Activate private balance” suite/test naming with testLabel. |
| e2e/desktop/tests/specs/accounts.swap.spec.ts | Standardizes multiple swap scenarios suite/test naming with [FROM-TO] prefixes. |
| .changeset/qaa-1434-harmonize-e2e-test-names.md | Adds patch changeset entries for the affected E2E packages/shared lib. |
|
|
||
| setTeamOwner(Team.WALLET_XP); | ||
| describe("User opens application", () => { | ||
| describe("Settings", () => { |
| }); | ||
|
|
||
| (isSmokeTestRun ? describe.skip : describe)("Open modular drawer via deeplinks", () => { | ||
| (isSmokeTestRun ? describe.skip : describe)("Deeplinks", () => { |
VicAlbr
marked this pull request as ready for review
July 31, 2026 09:56
Contributor
Rsdoctor Bundle Diff AnalysisFound 7 projects in monorepo, 7 projects with changes. 📊 Quick Summary
📋 Detailed Reports (Click to expand)📁 desktop-mainPath:
📁 desktop-preloaderPath:
📁 desktop-rendererPath:
📁 desktop-webviewDappPreloaderPath:
📁 desktop-webviewPreloaderPath:
📁 desktop-workersPath:
📁 mobilePath:
Generated by Rsdoctor GitHub Action |
Contributor
|
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 98 out of 98 changed files in this pull request and generated no new comments.
Suppressed comments (1)
e2e/mobile/specs/userOpensApplication.spec.ts:10
- The suite title is "Settings", but this test only exercises the onboarding/get-started flow (app.onboarding.*). This will mis-group the test in Allure and makes the suite name misleading.
Contributor
Author
|
LWD — @jeportie or @kentoforik what ticket should be used here ? pls provide a real B2CQA ticket 🙏 |
Contributor
Author
|
LWM — @jeportie or @kentoforik what ticket should be used here ? pls provide a real B2CQA ticket 🙏 |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✅ Checklist
npx changesetwas attached.playwright test --list): 317 tests / 37 files, zero duplicate-title errors, and XRAY ticket coverage byte-identical to the pre-change baseline (502 references). Mobile declaration count unchanged at 135. Typecheck,oxlintandoxfmt --checkclean on all three packages.📝 Description
Problem. LWD and LWM name the same functional test differently — desktop called it
[Cosmos] Delegate, mobile called itDelegate on Cosmos. QAs read an Allure report per platform after every CI run, and equivalent tests could not be matched between them, so cross-platform coverage could not be compared and gaps could not be identified reliably.Solution. Every test on both platforms now follows one convention:
[TICKER] -[ETH] - Add account[TICKER (Chain)] -[USDT (Ethereum)] - Send[FROM-TO] -[BTC-ETH] - Swap max amountChange app language to Françaisdescribe/ suite titles were aligned in the same pass (Delegate,Send,Swap - accepted,Earn v2,Settings, …).Supporting change.
Currency.testLabelwas added inlibs/live-e2e-shared/src/enum/Currency.ts. Three tickers are claimed by more than one currency —ETH(Ethereum / Sepolia / Base),USDTandUSDC(three chains each) — which produced five genuine title collisions. Playwright hard-fails on duplicate titles; jest does not, so mobile would have silently produced ambiguous Allure rows. The accessor resolves this once ([ETH (Base)],[USDT (Ethereum)]) instead of repeating the logic across ~10 call sites. Titles themselves stay plain template literals.Also fixed along the way
ui.swap.spec.tswas the only swap spec with noteamOwner, so it had noowner,parentSuiteorfeaturelabel and fell outside the Swap family in Allure.portfolio.spec.tscarriedB2CQA-4348but never calledaddTmsLink, so the ticket never rendered. Fixed.delegateSEI.spec.tsmerged intodelegate.spec.ts;[SEI] - Delegatenow sits with the other ten under theDelegatesuite.// to change:LIVE-19543(a dev ticket used as a test-case reference) andB2CQA-387-2(not a valid Jira key).A1/B2/C5scenario codes dropped from the swap-deeplink test and step names.🔍 Known limitations — deliberately out of scope
historyIdderives from the full test name on both platforms, so every renamed test starts a fresh trend line on the first run after merge. Worth warning the QAs before merging.[BTC]vs[INJ]for wallet assets,[ETH-USDC]vs[ETH-USDT]for the 1inch DEX flow. The action text and the XRAY ticket still pair them.B2CQA-3353/B2CQA-3354mean opposite scenarios on the two platforms. Pre-existing; left as-is.$TmsLinkat file level, so a ticket applies to every test in the file, which also makes the 91 LWD-only / 35 LWM-only coverage figures unreliable until that is fixed.🤖 CI
❓ Context
🧐 Checklist for the PR Reviewers