This repository was archived by the owner on Jul 15, 2022. It is now read-only.
feat: Replaced old DATA token logo with new - #1458
Open
jtakalai wants to merge 3 commits into
Open
Conversation
XDATA is the name of the "old" DATA token that is being migrated from. See official token migration page: https://streamr.network/token-migration/
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/ledgerhq/ledger-live-common/6uHR6B7vBfBD8dqtQh3spHzdcCKs |
jtakalai
changed the title
In the mock apparently there are all the currencies. Added XDATA there with same value as DATA.
gre
suggested changes
Dec 7, 2021
| <title>64px</title> | ||
| <desc>Created with Sketch.</desc> | ||
| <defs></defs> | ||
| <g id="64px" stroke="none" stroke-width="1" fill="none" fill-rule="evenodd"> |
Contributor
There was a problem hiding this comment.
Thanks for the contribution. could you merge master in? we have extra test that do some checks to ensure icons are fine.
Unfortunately, we can't afford to have id=, class= or <style> in these SVG because we will convert them back into react class.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context (issues, jira)
Streamr DATA went through a token migration.
See official token migration page: https://streamr.network/token-migration/
Description / Usage
Only logo files were updated here.
XDATA is the name of the "old" DATA token that is being migrated from.
Expectations
Test coverage not checked because: Not sure how you test for correct icons :D
No impact checked because: hopefully new icons will Just Work...