chore(lint): bump golangci-lint timeout to 10m - #102
Conversation
Lint hit the 5-minute timeout on the test/tpm-verifier-error-paths PR with `context loading failed: context deadline exceeded`. The job's package load alone took >5m on the self-hosted runner, leaving no budget for the actual analysis pass. 10m gives reliable headroom; the job typically completes in 2-3 minutes when not contending for runner cycles. The workflow step has no step-level timeout-minutes, so the golangci-lint --timeout flag in the Makefile is the only ceiling.
|
Claude finished @mpjunior92's task in 1m 5s —— View job Code Review
SummaryThis is a clean, well-scoped fix. The change is correct and the PR description is thorough. Here are my observations: The change (
|
|
Folding into #92 instead of a separate PR. |
Summary
Lint hit its 5-minute ceiling on PR #92 with:
```
level=error msg="Running error: context loading failed: failed to load packages: failed to load packages: failed to load with go/packages: context deadline exceeded"
level=error msg="Timeout exceeded: try increasing it by passing --timeout option"
```
The package-load step alone consumed the full 5 minutes on the self-hosted runner, leaving no budget for the actual analysis pass. Bumping to 10m gives reliable headroom — typical successful runs take 2-3 minutes when the runner isn't contending.
Diff
```diff
```
Why not also a workflow-level timeout-minutes
Checked `.github/workflows/main.yaml` — the `lint` job has no step-level `timeout-minutes`, so the GitHub Actions default (6h step ceiling) applies. The Makefile's `--timeout` is the only practical ceiling, and that's what we just bumped.
Test plan