Add Mailtrap email skills (sending, API auth, domain setup, contacts, sandbox testing)#165
Add Mailtrap email skills (sending, API auth, domain setup, contacts, sandbox testing)#165dieudonneAwa wants to merge 11 commits into
Conversation
Document the Mailtrap skill for sending transactional and bulk emails, including API and SMTP usage, best practices, and related skills.
This skill provides guidance on safely testing email sending in development and staging environments using Mailtrap Sandbox. It includes setup instructions and explains when to use this skill.
This skill provides guidance on verifying a sending domain in Mailtrap, including when to use it and required DNS records.
Added details about DKIM and DMARC records for Mailtrap domain verification.
This skill allows users to manage email contacts, lists, and segments using the Mailtrap Contacts API. It includes functionality for importing contacts, creating lists, and segmenting audiences.
This document provides guidance on authenticating API requests to Mailtrap using Bearer tokens, including setup instructions, best practices, and related skills.
![kilo-code-bot[bot]](https://avatars.githubusercontent.com/in/2193792?s=60&v=4){kind=small}
| --- | ||
| name: mailtrap-sending-emails | ||
| description: Send transactional and bulk emails via Mailtrap Email API and SMTP. Use when implementing email sending features, configuring API/SMTP credentials, choosing between transactional and bulk sending, or troubleshooting delivery issues. | ||
| license: MIT |
There was a problem hiding this comment.
WARNING: Missing required metadata.source.license_path for a contributed third-party skill
Per CONTRIBUTING.md, contributed skills sourced from an external repository (this one is author: mailtrap, sourced from mailtrap/mailtrap-skills) must set metadata.source.license_path pointing at the LICENSE file in the upstream repo (see the angular-component and frontend-design skills for the established pattern). The top-level license: MIT alone does not satisfy this for contributed skills, and there is no metadata.source.license_path anywhere in this file's frontmatter.
This same issue applies to all 5 new files in this PR: mailtrap-sending-emails, mailtrap-authorizing-api-requests, mailtrap-setting-up-sending-domain, mailtrap-managing-contacts, mailtrap-testing-with-sandbox.
Reply with @kilocode-bot fix it to have Kilo Code address this issue.
| description: Send transactional and bulk emails via Mailtrap Email API and SMTP. Use when implementing email sending features, configuring API/SMTP credentials, choosing between transactional and bulk sending, or troubleshooting delivery issues. | ||
| license: MIT | ||
| metadata: | ||
| category: business-marketing |
There was a problem hiding this comment.
WARNING: category: business-marketing is not a recognized marketplace category
bin/marketplace-generator-utils.ts defines MARKETPLACE_CATEGORIES as exactly business, data, development, observability, productivity, search, web-automation. business-marketing is not in that set and no other skill in the repo uses it (the closest existing category is business). Skill categories aren't validated at generation time the way MCP/agent categories are, so this won't fail CI, but it fragments the taxonomy for marketplace browsing/sorting.
All 5 new skills in this PR use category: business-marketing.
Reply with @kilocode-bot fix it to have Kilo Code address this issue.
| category: business-marketing | ||
| author: mailtrap | ||
| source: | ||
| repository: https://github.com/mailtrap/mailtrap-skills |
There was a problem hiding this comment.
WARNING: Missing required metadata.source.commit
CONTRIBUTING.md and AGENTS.md both require metadata.source.commit ("Full 40-character Git SHA... required for new imports") for every contributed skill's source block. bin/add-remote-skill.ts always populates this automatically when importing a skill, but it is absent here, so the pinned upstream revision can't be verified or diffed on future syncs.
Same issue affects all 5 new files in this PR.
Reply with @kilocode-bot fix it to have Kilo Code address this issue.
| author: mailtrap | ||
| source: | ||
| repository: https://github.com/mailtrap/mailtrap-skills | ||
| path: skills/sending-emails/SKILL.md |
There was a problem hiding this comment.
WARNING: metadata.source.path points at the SKILL.md file, not the skill directory
bin/add-remote-skill.ts and bin/update-skills.ts both treat source.path as a directory (sparse-checkout target, and update-skills.ts explicitly logs directory "${skill.source.path}" not found when checking it). Existing skills consistently point at the directory, e.g. angular-component's path: skills/angular-component. Here it's skills/sending-emails/SKILL.md (a file). When the marketplace's periodic refresh tooling (bin/update-skills.ts) runs against this source, it will attempt to sparse-checkout and copy a single file into what should be a full skill directory, breaking the sync for this skill.
Same issue affects all 5 new files in this PR (each path ends in /SKILL.md instead of the containing directory).
Reply with @kilocode-bot fix it to have Kilo Code address this issue.
| Mailtrap requires three DNS records to verify your domain: | ||
|
|
||
| **SPF** — Authorizes Mailtrap to send on your behalf: | ||
| **DKIM** — Signs outgoing emails cryptographically: |
There was a problem hiding this comment.
WARNING: SPF/DKIM/DMARC entries end with a colon but never show the actual record values
Lines 28-30 introduce each DNS record with a trailing colon ("Authorizes Mailtrap to send on your behalf:", "Signs outgoing emails cryptographically:", "Sets policy for failed authentication:") but no record value, format, or example (e.g. an actual v=spf1 ... / CNAME / v=DMARC1; p=... snippet) follows. Since documenting the required DNS records is this skill's stated purpose ("Required DNS Records"), a reader following it has no idea what to actually put in DNS, unlike the other four skills in this PR which all include concrete code/config examples.
Reply with @kilocode-bot fix it to have Kilo Code address this issue.
| ## Creating a Contact | ||
|
|
||
| ```javascript | ||
| const response = await fetch("https://mailtrap.io/api/contacts", { |
There was a problem hiding this comment.
SUGGESTION: Contacts API endpoint may be missing the required account_id path segment
https://mailtrap.io/api/contacts looks incomplete; Mailtrap's Contacts API is account-scoped and typically requires the form https://mailtrap.io/api/accounts/{account_id}/contacts. Worth verifying against current Mailtrap API docs before merge, since a copy-pasted example that 404s undermines the skill's usefulness.
Reply with @kilocode-bot fix it to have Kilo Code address this issue.
Code Review SummaryStatus: 4 Issues Found | Recommendation: Address before merge Overview
Issue Details (click to expand)WARNING
Issue Details - SUGGESTION
Notes
Fix these issues in Kilo Cloud Files Reviewed (5 files)
Previous Review Summary (commit e75387a)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit e75387a)Status: 6 Issues Found | Recommendation: Address before merge Overview
Issue Details (click to expand)WARNING
SUGGESTION
Notes
Files Reviewed (5 files)
Reviewed by claude-sonnet-5-20260630 · Input: 32 · Output: 9.4K · Cached: 554.9K Review guidance: REVIEW.md from base branch |
Fixed category from business-marketing to business and updated metadata path to remove /SKILL.md suffix, per Kilo marketplace validation requirements.
…equests Fixed category from business-marketing to business and updated metadata path to remove /SKILL.md suffix, per Kilo marketplace validation requirements.
Fixed category from business-marketing to business and updated metadata path to remove /SKILL.md suffix, per Kilo marketplace validation requirements.
…g-domain Fixed category from business-marketing to business and updated metadata path to remove /SKILL.md suffix, per Kilo marketplace validation requirements.
Fixed category from business-marketing to business and updated metadata path to remove /SKILL.md suffix, per Kilo marketplace validation requirements.
|
Hi! I've fixed all 5 skill files: updated the category from business-marketing to business and corrected the metadata path format (removed /SKILL.md suffix) across all skills. Ready for review whenever you get a chance, thanks! |
1 participant
Adds 5 Agent Skills for Mailtrap under skills/:
All skills include proper license and metadata.source frontmatter referencing the upstream mailtrap/mailtrap-skills repository.