fix(rewards): reconcile CommunityPool to bank balance at InitGenesis#364
fix(rewards): reconcile CommunityPool to bank balance at InitGenesis#364amathxbt wants to merge 1 commit into
Conversation
When the bank balance is lower than CommunityPool (e.g. after a faulty upgrade), BeginBlocker passes the pool pre-check but fails the bank send, causing a chain halt. Fix: cap CommunityPool to the actual bank balance at InitGenesis so the chain starts in a self-consistent state. Closes KiiChain#337
|
Warning Review limit reached
Next review available in: 56 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Summary
Root cause: When the bank balance of the rewards module account is lower than the
CommunityPoolaccounting (e.g. after a faulty upgrade restores old genesis state),InitGenesisonly logged the mismatch and continued. The chain started with phantom funds in the pool. Every subsequentBeginBlockercall then passed the pool pre-check but failed the bank send, causing a chain halt.Fix: Cap
CommunityPoolto the actual bank balance atInitGenesisso the chain starts in a self-consistent state. The discrepancy is still logged atERRORlevel for operator visibility.Files changed
x/rewards/keeper/genesis.go— reconcile pool to bank balance instead of just logging