fix(rewards): GenesisState.Validate checks CommunityPool covers active schedule#363
fix(rewards): GenesisState.Validate checks CommunityPool covers active schedule#363amathxbt wants to merge 1 commit into
Conversation
…maining GenesisState.Validate() did not verify the pool held enough funds for the active schedule. A genesis with a deficit passes validation but guarantees a future chain halt once BeginBlocker exhausts the bank balance. Fix: reject genesis states where pool < schedule remaining amount.
|
Warning Review limit reached
Next review available in: 56 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Summary
Bug:
GenesisState.Validate()did not verify thatCommunityPoolheld enough funds to satisfy the remaining obligations of an activeReleaseSchedule. A genesis file wherepool < (TotalAmount - ReleasedAmount)passed validation successfully, but the chain was guaranteed to halt as soon asBeginBlockerexhausted the actual bank balance.Fix: When the schedule is active, compute
remaining = TotalAmount - ReleasedAmountand reject genesis states wherepool.AmountOf(denom) < remaining.Files changed
x/rewards/types/genesis.go