Skip to content

Limit line length in framework/core to 120.#1554

Open
asuessenbach wants to merge 1 commit into
KhronosGroup:mainfrom
asuessenbach:format
Open

Limit line length in framework/core to 120.#1554
asuessenbach wants to merge 1 commit into
KhronosGroup:mainfrom
asuessenbach:format

Conversation

@asuessenbach

Copy link
Copy Markdown
Contributor

Description

Next part in limiting line length, now framework/core.

Build tested on Win11 with VS2022. Run tested on Win11 with NVidia GPU.

General Checklist:

Please ensure the following points are checked:

  • My code follows the coding style
  • I have reviewed file licenses
  • I have commented any added functions (in line with Doxygen)
  • I have commented any code that could be hard to understand
  • My changes do not add any new compiler warnings
  • My changes do not add any new validation layer errors or warnings
  • I have used existing framework/helper functions where possible
  • My changes do not add any regressions
  • I have tested every sample to ensure everything runs correctly
  • This PR describes the scope and expected impact of the changes I am making

Note: The Samples CI runs a number of checks including:

  • I have updated the header Copyright to reflect the current year (CI build will fail if Copyright is out of date)
  • My changes build on Windows, Linux, macOS and Android. Otherwise I have documented any exceptions

If this PR contains framework changes:

  • I did a full batch run using the batch command line argument to make sure all samples still work properly

Sample Checklist

If your PR contains a new or modified sample, these further checks must be carried out in addition to the General Checklist:

  • I have tested the sample on at least one compliant Vulkan implementation
  • If the sample is vendor-specific, I have tagged it appropriately
  • I have stated on what implementation the sample has been tested so that others can test on different implementations and platforms
  • Any dependent assets have been merged and published in downstream modules
  • For new samples, I have added a paragraph with a summary to the appropriate chapter in the readme of the folder that the sample belongs to e.g. api samples readme
  • For new samples, I have added a tutorial README.md file to guide users through what they need to know to implement code using this feature. For example, see conditional_rendering
  • For new samples, I have added a link to the Antora navigation so that the sample will be listed at the Vulkan documentation site

@asuessenbach

Copy link
Copy Markdown
Contributor Author

As usual :( the Clang Format Check is failing.
And I can't decipher what it's complaining about. Or how to resolve it.
What clang-format version is supposed to be run??

@asuessenbach
asuessenbach requested review from a team, SaschaWillems, gary-sweet and gpx1000 and removed request for gary-sweet July 16, 2026 11:57
@SaschaWillems

SaschaWillems commented Jul 17, 2026

Copy link
Copy Markdown
Collaborator

Yeah, that Clanf-Format thing is infuriating :(

Looking at the CI-setup it's using clang-tools:15.0.0, which has been released in 2022 and is a lot older than what's shipping with recent Visual Studio versions.

We should update CI to a version that matches what we use in VS. Which sadly also isn't latest (2026 seems to be clang-tools 19).

As a stop-gap you could install the same version CI uses via pip (python) and point Visual Studio to that.

@asuessenbach

Copy link
Copy Markdown
Contributor Author

Looking at the CI-setup it's using clang-tools:15.0.0

Switched from 15.0.7 down to 15.0.0. No effect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants