Limit line length in framework/core to 120.#1554
Open
asuessenbach wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
As usual :( the Clang Format Check is failing. |
asuessenbach
requested review from
a team,
SaschaWillems,
gary-sweet and
gpx1000
and removed request for
gary-sweet
July 16, 2026 11:57
Collaborator
|
Yeah, that Clanf-Format thing is infuriating :( Looking at the CI-setup it's using clang-tools:15.0.0, which has been released in 2022 and is a lot older than what's shipping with recent Visual Studio versions. We should update CI to a version that matches what we use in VS. Which sadly also isn't latest (2026 seems to be clang-tools 19). As a stop-gap you could install the same version CI uses via pip (python) and point Visual Studio to that. |
Contributor
Author
Switched from 15.0.7 down to 15.0.0. No effect. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Next part in limiting line length, now framework/core.
Build tested on Win11 with VS2022. Run tested on Win11 with NVidia GPU.
General Checklist:
Please ensure the following points are checked:
Note: The Samples CI runs a number of checks including:
If this PR contains framework changes:
batchcommand line argument to make sure all samples still work properlySample Checklist
If your PR contains a new or modified sample, these further checks must be carried out in addition to the General Checklist: