Add a new sample VK_KHR_device_address_commands. by gpx1000 · Pull Request #1547 · KhronosGroup/Vulkan-Samples

gpx1000 · 2026-06-12T08:22:58Z

This requires updating Vulkan.

Tested in Ubuntu Linux on NVIDIA.

Description

Please include a summary of the change, new sample or fixed issue. Please also include relevant motivation and context.
Please read the contribution guidelines

Fixes #

General Checklist:

Please ensure the following points are checked:

My code follows the coding style
[ X I have reviewed file licenses
I have commented any added functions (in line with Doxygen)
I have commented any code that could be hard to understand
My changes do not add any new compiler warnings
My changes do not add any new validation layer errors or warnings
I have used existing framework/helper functions where possible
My changes do not add any regressions
I have tested every sample to ensure everything runs correctly
This PR describes the scope and expected impact of the changes I am making

Note: The Samples CI runs a number of checks including:

I have updated the header Copyright to reflect the current year (CI build will fail if Copyright is out of date)
My changes build on Windows, Linux, macOS and Android. Otherwise I have documented any exceptions

If this PR contains framework changes:

[ X I did a full batch run using the batch command line argument to make sure all samples still work properly

Sample Checklist

If your PR contains a new or modified sample, these further checks must be carried out in addition to the General Checklist:

I have tested the sample on at least one compliant Vulkan implementation
If the sample is vendor-specific, I have tagged it appropriately
I have stated on what implementation the sample has been tested so that others can test on different implementations and platforms
Any dependent assets have been merged and published in downstream modules
For new samples, I have added a paragraph with a summary to the appropriate chapter in the readme of the folder that the sample belongs to e.g. api samples readme
For new samples, I have added a tutorial README.md file to guide users through what they need to know to implement code using this feature. For example, see conditional_rendering
For new samples, I have added a link to the Antora navigation so that the sample will be listed at the Vulkan documentation site

…ng Vulkan.

gary-sweet · 2026-06-15T09:11:21Z

This seems to run just fine for me, but I do get one validation error:

[error] 555635515 - VUID-VkDeviceCreateInfo-pNext-02830: vkCreateDevice(): pCreateInfo->pNext chain includes a VkPhysicalDeviceVulkan12Features structure, then it must not include a VkPhysicalDeviceHostQueryResetFeatures structure. The features in VkPhysicalDeviceHostQueryResetFeatures were promoted in Vulkan 1.2 and is also found in VkPhysicalDeviceVulkan12Features. To prevent one feature setting something to VK_TRUE and the other to VK_FALSE, only one struct containing the feature is allowed.
pNext chain: VkDeviceCreateInfo::pNext -> [VK_STRUCTURE_TYPE_LOADER_DEVICE_CREATE_INFO] -> [VK_STRUCTURE_TYPE_LOADER_DEVICE_CREATE_INFO] -> [VkPhysicalDeviceSynchronization2Features] -> [VkPhysicalDeviceDeviceAddressCommandsFeaturesKHR] -> [VkPhysicalDeviceVulkan12Features] -> [VkPhysicalDeviceHostQueryResetFeatures] -> [VkPhysicalDevicePerformanceQueryFeaturesKHR].
The Vulkan spec states: If the pNext chain includes a VkPhysicalDeviceVulkan12Features structure, then it must not include a VkPhysicalDevice8BitStorageFeatures, VkPhysicalDeviceShaderAtomicInt64Features, VkPhysicalDeviceShaderFloat16Int8Features, VkPhysicalDeviceDescriptorIndexingFeatures, VkPhysicalDeviceScalarBlockLayoutFeatures, VkPhysicalDeviceImagelessFramebufferFeatures, VkPhysicalDeviceUniformBufferStandardLayoutFeatures, VkPhysicalDeviceShaderSubgroupExtendedTypesFeatures, VkPhysicalDeviceSeparateDepthStencilLayoutsFeatures, VkPhysicalDeviceHostQueryResetFeatures, VkPhysicalDeviceTimelineSemaphoreFeatures, VkPhysicalDeviceBufferDeviceAddressFeatures, or VkPhysicalDeviceVulkanMemoryModelFeatures structure (https://docs.vulkan.org/spec/latest/chapters/devsandqueues.html#VUID-VkDeviceCreateInfo-pNext-02830)

Copilot

Pull request overview

This PR adds a new Vulkan-Samples extension sample showcasing VK_KHR_device_address_commands, demonstrating a GPU-driven rendering path that records bind/fill/update/draw operations using device addresses (instead of VkBuffer handles), along with accompanying documentation and build/docs integration.

Changes:

Added a new device_address_commands extension sample implementation (C++), including runtime loading of VK_KHR_device_address_commands entry points and address-range barriers.
Added GLSL + Slang shader implementations for compute-driven animation/culling and indirect drawing.
Integrated the sample into the extensions README, Antora navigation, and the sample build order list.

Reviewed changes

Copilot reviewed 16 out of 22 changed files in this pull request and generated 8 comments.

Show a summary per file

File	Description
`samples/extensions/device_address_commands/device_address_commands.cpp`	New sample implementation using address-based fill/update/bind/draw + memory-range barriers
`samples/extensions/device_address_commands/device_address_commands.h`	Sample interface + shared constants and push-constant struct definitions
`samples/extensions/device_address_commands/CMakeLists.txt`	Build integration for the new sample and shader compilation inputs
`shaders/device_address_commands/glsl/update_objects.comp`	Compute shader (GLSL) that animates objects, culls, and emits indirect commands
`shaders/device_address_commands/glsl/render.vert`	Vertex shader (GLSL) reading camera/transforms via buffer references in push constants
`shaders/device_address_commands/glsl/render.frag`	Fragment shader (GLSL) outputting per-instance color
`shaders/device_address_commands/slang/update_objects.comp.slang`	Compute shader (Slang) equivalent using pointer-based access
`shaders/device_address_commands/slang/render.vert.slang`	Vertex shader (Slang) equivalent using pointer-based access
`shaders/device_address_commands/slang/render.frag.slang`	Fragment shader (Slang) equivalent
`samples/extensions/device_address_commands/README.adoc`	New tutorial-style documentation for the sample and extension concepts
`samples/extensions/README.adoc`	Adds the new sample to the Extensions samples README list
`samples/CMakeLists.txt`	Adds the sample to the global sample ordering list
`antora/modules/ROOT/nav.adoc`	Adds the new sample docs page to the Antora navigation

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

SaschaWillems

Sample is working for me on WIn11 and an nv RTX 4070.

I noticed a few naming/styling related thing in code that should be improved. But nothing functional.

asuessenbach · 2026-07-15T09:52:40Z

+		return false;
+	}
+
+	volkLoadDevice(get_device().get_handle());


Do you need the device specific functions?
volkLoadInstance is already called by the framework. And I think, volkLoadDevice should be called there as well.

asuessenbach · 2026-07-15T09:53:54Z

+	// The compute shader sets firstInstance to the object index so the vertex
+	// shader can index the transform array.  Non-zero firstInstance requires
+	// this core feature (Vulkan 1.0, universally available on desktop).
+	gpu.get_mutable_requested_features().drawIndirectFirstInstance = VK_TRUE;


Maybe check for gpu.get_features().drawIndirectFirstInstance support first?

asuessenbach · 2026-07-15T09:56:23Z

+
+	// vkCmdDrawIndexedIndirectCount2KHR is a multi-draw indirect variant;
+	// multiDrawIndirect is required when maxDrawCount > 1.
+	gpu.get_mutable_requested_features().multiDrawIndirect = VK_TRUE;


Maybe check for gpu.get_features().multiDrawIndirect support first?

asuessenbach · 2026-07-15T12:21:55Z

+	// Buffer device address is core in Vulkan 1.2 and required by
+	// VK_KHR_device_address_commands.  We also request the KHR extension
+	// name so older loaders find it correctly.
+	add_device_extension(VK_KHR_BUFFER_DEVICE_ADDRESS_EXTENSION_NAME, /*optional=*/true);


As you already state in the comment, VK_KHR_device_address_commands is promoted to Vulkan 1.2. And as you already require Vulkan 1.3 (-> get_api_version), you don't need to add the VK_KHR_BUFFER_DEVICE_ADDRESS_EXTENSION_NAME extension.
Moreover, I think you're always using the non-KHR names, which makes adding this extension even more superfluous.

asuessenbach · 2026-07-15T12:23:39Z

+	// VK_KHR_device_address_commands.  We also request the KHR extension
+	// name so older loaders find it correctly.
+	add_device_extension(VK_KHR_BUFFER_DEVICE_ADDRESS_EXTENSION_NAME, /*optional=*/true);
+	add_device_extension(VK_KHR_DRAW_INDIRECT_COUNT_EXTENSION_NAME);


VK_KHR_DRAW_INDIRECT_COUNT_EXTENSION_NAME is also promoted to Vulkan 1.2, so no need to add it here.

asuessenbach · 2026-07-15T12:51:32Z

+add_device_extension(VK_KHR_BUFFER_DEVICE_ADDRESS_EXTENSION_NAME, /*optional=*/true);
+----
+
+=== Loading function pointers


This part has gone.

asuessenbach · 2026-07-15T12:58:00Z

+	                   0, sizeof(pc), &pc);
+
+	// 4 groups × 64 threads = 256 invocations, one per object.
+	vkCmdDispatch(cmd, kObjectCount / 64, 1, 1);


This only works with kObjectCount being an integer multiple of 64.
And where does that magic 64 come from?

asuessenbach · 2026-07-15T13:11:03Z

+== Further reading
+
+* Vulkan specification: https://registry.khronos.org/vulkan/specs/latest/man/html/VK_KHR_device_address_commands.html[VK_KHR_device_address_commands]
+* Khronos proposal: https://docs.vulkan.org/features/latest/features/proposals/VK_KHR_device_address_commands.html[Feature proposal]


Maybe link to https://registry.khronos.org/vulkan/specs/latest/man/html/VK_KHR_device_address_commands.html, instead?

Add a new sample VK_KHR_device_address_commands. This requires updati…

6fd62e9

…ng Vulkan.

Fix for VUID error.

d65ccf6

gary-sweet previously approved these changes Jun 16, 2026

View reviewed changes

marty-johnson59 requested review from SaschaWillems and Copilot June 19, 2026 15:02

Copilot started reviewing on behalf of marty-johnson59 June 19, 2026 15:03 View session

Copilot AI reviewed Jun 19, 2026

View reviewed changes

SaschaWillems requested changes Jun 22, 2026

View reviewed changes

Address Sascha's feedback.

ed5b58a

gpx1000 dismissed gary-sweet’s stale review via ed5b58a June 24, 2026 16:02

gpx1000 added 2 commits June 24, 2026 09:26

Address feedback from github copilot.

4b2a100

clang-format corrections.

0749137

SaschaWillems previously approved these changes Jun 25, 2026

View reviewed changes

Merge branch 'main' into device-address-commands

fce5c33

tomek-brcm previously approved these changes Jul 13, 2026

View reviewed changes

switch to using volk for function loads.

0d94a17

gpx1000 dismissed stale reviews from tomek-brcm and SaschaWillems via 0d94a17 July 13, 2026 16:02

asuessenbach reviewed Jul 15, 2026

View reviewed changes

Uh oh!

Conversation

gpx1000 commented Jun 12, 2026

Description

General Checklist:

Sample Checklist

Uh oh!

gary-sweet commented Jun 15, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

SaschaWillems left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

asuessenbach Jul 15, 2026

Choose a reason for hiding this comment

Uh oh!

asuessenbach Jul 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

asuessenbach Jul 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

asuessenbach Jul 15, 2026

Choose a reason for hiding this comment

Uh oh!

asuessenbach Jul 15, 2026

Choose a reason for hiding this comment

Uh oh!

asuessenbach Jul 15, 2026

Choose a reason for hiding this comment

Uh oh!

asuessenbach Jul 15, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

asuessenbach Jul 15, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

asuessenbach Jul 15, 2026 •

edited

Loading

asuessenbach Jul 15, 2026 •

edited

Loading