[Interactive Graph] Vector graph description polish.#3799
Open
catandthemachines wants to merge 2 commits into
Open
[Interactive Graph] Vector graph description polish.#3799catandthemachines wants to merge 2 commits into
catandthemachines wants to merge 2 commits into
Conversation
Contributor
|
Size Change: +256 B (+0.05%) Total Size: 514 kB 📦 View Changed
ℹ️ View Unchanged
|
Contributor
npm Snapshot: PublishedGood news!! We've packaged up the latest commit from this PR (bb6a7f7) and published it to npm. You Example: pnpm add @khanacademy/perseus@PR3799If you are working in Khan Academy's frontend, you can run the below command. ./dev/tools/bump_perseus_version.ts -t PR3799If you are working in Khan Academy's webapp, you can run the below command. ./dev/tools/bump_perseus_version.js -t PR3799 |
catandthemachines
requested review from
Evelas78,
handeyeco,
ivyolamit and
nishasy
| }); | ||
|
|
||
| it("returns the tip label at the tip (index 1)", () => { | ||
| it("returns the head label at the head (index 1)", () => { |
Member
Author
There was a problem hiding this comment.
Changed the language of the "tip" point to "head" per https://www.nwea.org/uploads/2022/11/Image-Description-Guidelines-for-Assessments_NWEA_2021.pdf and https://khanacademy.atlassian.net/wiki/spaces/LC/pages/4817355148/Vector
ivyolamit
approved these changes
Jun 18, 2026
ivyolamit
left a comment
ivyolamit
left a comment
Contributor
There was a problem hiding this comment.
Look logical to me 👍🏼
| Before | After |
|---|---|
 |
 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Updating the Vector graph descriptions so the screen reader copy matches the Vector outline doc, and adding magnitude/direction context that is essential for all learners:
srVectorTipPoint→srVectorHeadPointstring key).Follows the same pattern as the exponential (#3786) and logarithm (#3798) description polish.
Issue: LEMS-4124
Test plan:
Run
pnpm storybookand open Widgets → Interactive Graph → Vector. These are screen-reader strings, so verify with a screen reader or by inspecting the elementaria-labels /aria-describedbytext. Check: