Render Grapher axis labels as TeX when the Interactive Graph UI components are used#3791
Merged
Conversation
…Interactive Graph UI components are used
Contributor
|
Size Change: +43 B (+0.01%) Total Size: 510 kB 📦 View Changed
ℹ️ View Unchanged
|
SonicScrewdriver
approved these changes
Jun 17, 2026
SonicScrewdriver
left a comment
SonicScrewdriver
left a comment
Contributor
There was a problem hiding this comment.
Looks great! I'm happy to approve as-is, given that grapher was already doing this itself.
…active-graph` feature flag is on, Grapher axis labels are now interpreted as TeX.
Contributor
npm Snapshot: PublishedGood news!! We've packaged up the latest commit from this PR (12918ef) and published it to npm. You Example: pnpm add @khanacademy/perseus@PR3791If you are working in Khan Academy's frontend, you can run the below command. ./dev/tools/bump_perseus_version.ts -t PR3791If you are working in Khan Academy's webapp, you can run the below command. ./dev/tools/bump_perseus_version.js -t PR3791 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
The old Grapher UI assumed axis labels were formatted as bare TeX. Interactive
Graph assumes they are text which may contain TeX surrounded by
$...$delimiters. This means we have to adapt the label format when rendering a
Grapher using the Interactive Graph components.
Issue: LEMS-4285
Test plan:
View this exercise with the
grapher-to-interactive-graphfeature flag turnedon for your account:
The graph axis labels (
x,y) should be italicized.