[Interactive Graph] Ensure we have defaults for labels in our Locked Figures in order to prevent confusing issues that prevent publishing#3765
Draft
Evelas78 wants to merge 5 commits into
Draft
Conversation
…n-order-to-prevent-confusing-issues-that-prevent-publishing] [Interactive Graph] Ensure we have defaults for labels in our Locked Figures in order to prevent confusing issues that prevent publishing Ensure defaults exist in both our parser and editor logic Issue: https://khanacademy.atlassian.net/browse/LEMS-4215 Test plan: - TBD
Contributor
|
Size Change: +36 B (+0.01%) Total Size: 508 kB 📦 View Changed
ℹ️ View Unchanged
|
Contributor
npm Snapshot: PublishedGood news!! We've packaged up the latest commit from this PR (9d23403) and published it to npm. You Example: pnpm add @khanacademy/perseus@PR3765If you are working in Khan Academy's frontend, you can run the below command. ./dev/tools/bump_perseus_version.ts -t PR3765If you are working in Khan Academy's webapp, you can run the below command. ./dev/tools/bump_perseus_version.js -t PR3765 |
…n-order-to-prevent-confusing-issues-that-prevent-publishing] docs(changeset): Default addition to parser and editor for labels in locked figures
…n-order-to-prevent-confusing-issues-that-prevent-publishing] Added a test to ensure parser is changing defaults
…n-order-to-prevent-confusing-issues-that-prevent-publishing] docs(changeset): Added defaults to parser for color and size
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Ensure defaults exist in both our parser and editor logic
Issue: https://khanacademy.atlassian.net/browse/LEMS-4215
Test plan: