Skip to content

[Preview NG] Export PreviewContent and PreviewWithIframe from perseus-editor#3764

Open
jeremywiebe wants to merge 2 commits into
jer/preview-ng-10-exercise-content-variantfrom
jer/preview-ng-11-export-preview-symbols
Open

[Preview NG] Export PreviewContent and PreviewWithIframe from perseus-editor#3764
jeremywiebe wants to merge 2 commits into
jer/preview-ng-10-exercise-content-variantfrom
jer/preview-ng-11-export-preview-symbols

Conversation

@jeremywiebe

Copy link
Copy Markdown
Collaborator

Summary

Exports two symbols from @khanacademy/perseus-editor that are needed by consumers:

  • PreviewWithIframe — the component that hosts the preview iframe and the parent↔iframe message bridge.
  • PreviewContent — the discriminated-union type describing what a preview renders (question, hint, article-section, article-all, exercise).

Both already lived in the package; this just adds them to the public entry point (src/index.ts). No behavior change.

Issue: LEMS-3741

Test plan

  • pnpm typecheck passes — the new re-exports resolve.
  • No runtime change; nothing to exercise manually.

@jeremywiebe jeremywiebe self-assigned this Jun 11, 2026
@jeremywiebe jeremywiebe marked this pull request as ready for review June 11, 2026 19:14
@jeremywiebe jeremywiebe changed the title Export PreviewContent and PreviewWithIframe from perseus-editor [Preview NG] Export PreviewContent and PreviewWithIframe from perseus-editor Jun 11, 2026
@github-actions

github-actions Bot commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

npm Snapshot: Published

Good news!! We've packaged up the latest commit from this PR (9df41d9) and published it to npm. You
can install it using the tag PR3764.

Example:

pnpm add @khanacademy/perseus@PR3764

If you are working in Khan Academy's frontend, you can run the below command.

./dev/tools/bump_perseus_version.ts -t PR3764

If you are working in Khan Academy's webapp, you can run the below command.

./dev/tools/bump_perseus_version.js -t PR3764

@github-actions

github-actions Bot commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

Size Change: +7 B (0%)

Total Size: 508 kB

📦 View Changed
Filename Size Change
packages/perseus-editor/dist/es/index.js 105 kB +7 B (+0.01%)
ℹ️ View Unchanged
Filename Size
packages/kas/dist/es/index.js 20.6 kB
packages/keypad-context/dist/es/index.js 1 kB
packages/kmath/dist/es/index.js 6.32 kB
packages/math-input/dist/es/index.js 98.5 kB
packages/math-input/dist/es/strings.js 1.61 kB
packages/perseus-core/dist/es/index.item-splitting.js 12 kB
packages/perseus-core/dist/es/index.js 26.3 kB
packages/perseus-linter/dist/es/index.js 9.8 kB
packages/perseus-score/dist/es/index.js 10.2 kB
packages/perseus-utils/dist/es/index.js 403 B
packages/perseus/dist/es/index.js 200 kB
packages/perseus/dist/es/strings.js 8.6 kB
packages/pure-markdown/dist/es/index.js 1.39 kB
packages/simple-markdown/dist/es/index.js 6.71 kB

compressed-size-action

@anakaren-rojas anakaren-rojas left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just missing the changeset!

@jeremywiebe jeremywiebe force-pushed the jer/preview-ng-11-export-preview-symbols branch from 53ab3b3 to 9df41d9 Compare June 11, 2026 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants