POC Improve disabled editor contrast by letting Wonder Blocks own the disabled state#3761
Draft
ivyolamit wants to merge 10 commits into
Draft
POC Improve disabled editor contrast by letting Wonder Blocks own the disabled state#3761ivyolamit wants to merge 10 commits into
ivyolamit wants to merge 10 commits into
Conversation
… editor contrast by letting Wonder Blocks own the disabled state
…dge to replace the deprecated pill component
Contributor
|
Size Change: +1.12 kB (+0.22%) Total Size: 509 kB 📦 View Changed
ℹ️ View Unchanged
|
ivyolamit
commented
Jun 11, 2026
| @@ -537,6 +548,7 @@ class AnswerOption extends React.Component< | |||
| <Strut size={spacing.small_12} /> | |||
Contributor
Author
There was a problem hiding this comment.
Remove strut, this is deprecated WB component
…e button disabled
ivyolamit
commented
Jun 11, 2026
| ); | ||
| } | ||
|
|
||
| const styles = StyleSheet.create({ |
ivyolamit
commented
Jun 11, 2026
| @@ -461,7 +465,11 @@ class ExpressionEditor extends React.Component<Props, State> { | |||
| <View style={{gap: spacing.xSmall_8}}>{answerOptions}</View> | |||
|
|
|||
| <Strut size={spacing.small_12} /> | |||
ivyolamit
commented
Jun 11, 2026
|
|
||
| type ChangeFn = typeof Changeable.change; | ||
|
|
||
| const fieldStyles = StyleSheet.create({ |
…isabled in locked figures
… add editingDisabled
…, add editingDisabled
ivyolamit
commented
Jun 12, 2026
| editingDisabled: boolean; | ||
| }; | ||
|
|
||
| type AnswerProps = { |
Contributor
Author
There was a problem hiding this comment.
change to interface
ivyolamit
commented
Jun 12, 2026
| cursor: "not-allowed", | ||
| }, | ||
|
|
||
| disabledLink: { |
ivyolamit
commented
Jun 12, 2026
| selectedStyle: { | ||
| backgroundColor: "#ddd", | ||
| }, | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Issue: LEMS-4131
Test plan: