Skip to content

Delete most InputNumber code, replace with NumericInput#3760

Open
benchristel wants to merge 26 commits into
mainfrom
benc/input-number-v2-take-3
Open

Delete most InputNumber code, replace with NumericInput#3760
benchristel wants to merge 26 commits into
mainfrom
benc/input-number-v2-take-3

[benc/input-number-v2-take-3] Delete unused test data file

2f62c39
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
GitHub Actions / PR Comparison: Schema Change succeeded Jun 11, 2026 in 0s

PR Comparison: Schema Change: Changes Acknowledged ✅

This PR contains critical changes to Perseus that affect published data. Please review the changes and note that you may need to coordinate deployment of these changes with other teams at Khan Academy, especially with #cp-eng to publish a content update.

Usually this means you need to update the Go parser that Content Platform maintains. Follow these steps on how to release. See this list of post-mortems for more information.

Acknowledged via the schema-change-ack label. Remove the label to require re-acknowledgement.

View diff
diff --unified /home/github/work/_temp/branch-compare/base/schema.d.ts /home/github/work/_temp/branch-compare/pr/schema.d.ts
--- /home/github/work/_temp/branch-compare/base/schema.d.ts	2026-06-11 18:47:23.598315710 +0000
+++ /home/github/work/_temp/branch-compare/pr/schema.d.ts	2026-06-11 18:47:15.258018614 +0000
@@ -1201,24 +1201,9 @@
     location: string;
     static?: boolean;
   };
-  export type PerseusInputNumberAnswerType =
-    | "number"
-    | "decimal"
-    | "integer"
-    | "rational"
-    | "improper"
-    | "mixed"
-    | "percent"
-    | "pi";
-  export type PerseusInputNumberWidgetOptions = {
-    answerType?: PerseusInputNumberAnswerType;
-    inexact?: boolean;
-    maxError?: number | string;
-    rightAlign?: boolean;
-    simplify: "required" | "optional" | "enforced";
-    size: "normal" | "small";
-    value: string | number;
-  };
+  export type PerseusInputNumberAnswer = PerseusNumericInputAnswer;
+  export type PerseusInputNumberWidgetOptions =
+    PerseusNumericInputWidgetOptions;
   export type PerseusMoleculeRendererWidgetOptions = {
     widgetId: string;
     rotationAngle?: number;