[Interactive Graph] Improve graph instruction and add repeat shortcut#3745
Open
ivyolamit wants to merge 3 commits into
Open
[Interactive Graph] Improve graph instruction and add repeat shortcut#3745ivyolamit wants to merge 3 commits into
ivyolamit wants to merge 3 commits into
Conversation
Contributor
|
Size Change: +353 B (+0.07%) Total Size: 508 kB 📦 View Changed
ℹ️ View Unchanged
|
Contributor
npm Snapshot: PublishedGood news!! We've packaged up the latest commit from this PR (571246e) and published it to npm. You Example: pnpm add @khanacademy/perseus@PR3745If you are working in Khan Academy's frontend, you can run the below command. ./dev/tools/bump_perseus_version.ts -t PR3745If you are working in Khan Academy's webapp, you can run the below command. ./dev/tools/bump_perseus_version.js -t PR3745 |
…] Improve graph instruction and add repeat shortcut
…nstruction and add repeat shortcut
ivyolamit
force-pushed
the
LEMS-4120-instructions-shortcut
branch
from
b8362f9 to
571246e
Compare
Member
|
Just adding a note that this short cut isn't even working in Windows + NVDA. We'll need to investigate and troubleshoot this a bit more to ensure we have a version that works. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Reworks the screen reader-only interactive-graph instructions to lead with a focus-mode warning and end with an on-demand repeat hint, and adds the Insert + I shortcut that repeats the instructions while the graph is focused.
Issue: LEMS-4120
Test plan: