[Interactive Graph] Improve graph instruction and add repeat shortcut - #3745
[Interactive Graph] Improve graph instruction and add repeat shortcut#3745ivyolamit wants to merge 3 commits into
Conversation
|
Size Change: +353 B (+0.07%) Total Size: 508 kB 📦 View Changed
ℹ️ View Unchanged
|
npm Snapshot: PublishedGood news!! We've packaged up the latest commit from this PR (571246e) and published it to npm. You Example: pnpm add @khanacademy/perseus@PR3745If you are working in Khan Academy's frontend, you can run the below command. ./dev/tools/bump_perseus_version.ts -t PR3745If you are working in Khan Academy's webapp, you can run the below command. ./dev/tools/bump_perseus_version.js -t PR3745 |
…] Improve graph instruction and add repeat shortcut
…nstruction and add repeat shortcut
b8362f9 to
571246e
Compare
|
Just adding a note that this short cut isn't even working in Windows + NVDA. We'll need to investigate and troubleshoot this a bit more to ensure we have a version that works. |
| - DOM reorder so the instructions `<View>` is the first sr-only child inside the graph wrapper (LEMS-4121; OQ4). | ||
| - Bounded vs. unlimited instruction-string split (LEMS-4120; OQ2a decision B), including the leading mode-toggle warning (OQ2b decision A) and the on-demand-shortcut sentence (OQ2c decision A). | ||
| - Insert + I (Windows) / Fn + Enter + I (macOS) keyboard shortcut to repeat the instruction string on demand (LEMS-4120; OQ2c decision A). Platform-detected dual binding. | ||
| - Insert + I keyboard shortcut to repeat the instruction string on demand (LEMS-4120; OQ2c). **Windows-only** — the originally-planned Fn + Enter + I macOS binding was dropped during implementation: Macs have no Insert key (Fn + Return reports as `key: "Enter"`, never "Insert") and macOS VoiceOver doesn't use Insert as a modifier, so the chord can't fire on a Mac. Mac SR users re-focus the graph to re-hear the instructions. No platform detection needed. |
There was a problem hiding this comment.
Should we really be doing something that's only supported on Windows and not Mac?
Are we identifying if the user is on Windows/Mac to conditionally change the instructions? (I didn't see that when doing a rough pass over the PR)
How does this affect development and QE? Adding a feature that many people won't be able to test because we don't have Windows?
I would recommend not adding a feature that's only available to one OS, but if we still decide to, this should probably be a bigger conversation in LEMS.
|
Based on team discussion we will hold off implementation for future work. |
3 participants
Summary:
Reworks the screen reader-only interactive-graph instructions to lead with a focus-mode warning and end with an on-demand repeat hint, and adds the Insert + I shortcut that repeats the instructions while the graph is focused.
Issue: LEMS-4120
Test plan: