Skip to content

Fix generate deprecation warning typo - #105

Merged
bernalde merged 1 commit into
mainfrom
fix/generate-deprecation-warning
Jun 18, 2026
Merged

Fix generate deprecation warning typo#105
bernalde merged 1 commit into
mainfrom
fix/generate-deprecation-warning

Conversation

@bernalde

Copy link
Copy Markdown
Member

Summary

  • Fix the misspelled Depraction Warning text emitted by deprecated synthesis generate calls.
  • Add synthesis unit assertions for the corrected warning text.

Tests

  • git diff --check
  • julia +1.12 --project=. -e 'using Test, Statistics, QUBOTools; include("test/unit/library/synthesis.jl"); test_synthesis()'
  • QUBOTOOLS_SCALE_TESTS=true QUBOTOOLS_SCALE_MAX_N=1000 julia +1.12 --project=. test/scale/runtests.jl
  • julia +1.12 --project=. -e 'using Pkg; Pkg.test()'

@github-actions

Copy link
Copy Markdown

Performance Report - main vs. dev

Timings are reported for the batched benchmark operations as minimum (median) ± std, and comparison uses a 15.00% tolerance to reduce false positives on shared runners.

case main dev diff
/constructors/n=128/Model/MOI/bool 253.142 μs (277.337 μs) ± 384.808 μs 254.755 μs (282.627 μs) ± 422.800 μs invariant (0.64%)
/constructors/n=128/Model 670.269 μs (708.085 μs) ± 826.041 μs 666.492 μs (702.389 μs) ± 970.658 μs invariant (-0.56%)
/constructors/n=2048/Model/MOI/bool 8.600 ms (8.949 ms) ± 22.742 ms 8.647 ms (9.214 ms) ± 18.941 ms invariant (0.54%)
/constructors/n=2048/Model 27.452 ms (30.591 ms) ± 22.623 ms 27.336 ms (30.444 ms) ± 23.108 ms invariant (-0.42%)
/constructors/n=384/Model/MOI/bool 801.534 μs (867.437 μs) ± 456.177 μs 810.340 μs (879.119 μs) ± 503.561 μs invariant (1.10%)
/constructors/n=384/Model 2.727 ms (2.843 ms) ± 1.333 ms 2.709 ms (2.862 ms) ± 1.593 ms invariant (-0.67%)
/constructors/tsp/cities=36/Model/MOI/bool 32.475 ms (34.540 ms) ± 54.068 ms 32.790 ms (35.698 ms) ± 56.884 ms invariant (0.97%)
/constructors/tsp/cities=36/Model 60.579 ms (64.693 ms) ± 60.820 ms 60.728 ms (65.300 ms) ± 52.503 ms invariant (0.25%)
/conversions/n=128/form/Dict 176.910 μs (207.316 μs) ± 2.630 ms 192.419 μs (237.884 μs) ± 2.732 ms invariant (8.77%)
/conversions/n=128/form/Matrix/Float32 42.870 μs (52.128 μs) ± 145.566 μs 44.212 μs (56.065 μs) ± 200.186 μs invariant (3.13%)
/conversions/n=128/form/Matrix 71.984 μs (80.820 μs) ± 2.818 ms 65.302 μs (86.597 μs) ± 2.776 ms invariant (-9.28%)
/conversions/n=128/form/SparseMatrixCSC 107.791 μs (121.787 μs) ± 225.854 μs 109.855 μs (129.712 μs) ± 324.861 μs invariant (1.91%)
/conversions/n=128/ising/Matrix 66.404 μs (81.507 μs) ± 2.811 ms 62.206 μs (85.289 μs) ± 2.761 ms invariant (-6.32%)
/conversions/n=128/qubo/Matrix/min 704.934 μs (760.202 μs) ± 6.918 ms 704.513 μs (786.516 μs) ± 6.118 ms invariant (-0.06%)
/conversions/n=128/qubo/Matrix 373.977 μs (416.286 μs) ± 5.092 ms 393.273 μs (438.668 μs) ± 4.668 ms invariant (5.16%)
/conversions/n=384/form/Dict 514.539 μs (597.524 μs) ± 3.341 ms 617.521 μs (710.906 μs) ± 3.849 ms regression (20.01%)
/conversions/n=384/form/Matrix/Float32 259.323 μs (321.825 μs) ± 11.662 ms 245.618 μs (381.606 μs) ± 10.694 ms invariant (-5.28%)
/conversions/n=384/form/Matrix 447.284 μs (590.982 μs) ± 18.766 ms 465.699 μs (706.327 μs) ± 17.605 ms invariant (4.12%)
/conversions/n=384/form/SparseMatrixCSC 343.009 μs (375.589 μs) ± 9.083 ms 333.402 μs (375.650 μs) ± 7.700 ms invariant (-2.80%)
/conversions/n=384/ising/Matrix 452.203 μs (596.883 μs) ± 19.159 ms 447.644 μs (707.589 μs) ± 17.029 ms invariant (-1.01%)
/conversions/n=384/qubo/Matrix/min 6.362 ms (6.916 ms) ± 37.385 ms 6.655 ms (6.955 ms) ± 33.647 ms invariant (4.60%)
/conversions/n=384/qubo/Matrix 3.419 ms (3.767 ms) ± 29.874 ms 3.575 ms (3.859 ms) ± 27.037 ms invariant (4.55%)
/evaluation/n=128/value/dense-form 345.023 μs (372.534 μs) ± 614.001 μs 345.444 μs (372.329 μs) ± 547.601 μs invariant (0.12%)
/evaluation/n=128/value/dict-form 239.136 μs (239.908 μs) ± 6.138 μs 256.908 μs (257.891 μs) ± 6.954 μs invariant (7.43%)
/evaluation/n=128/value/model 49.311 μs (76.643 μs) ± 627.968 μs 49.262 μs (51.066 μs) ± 375.318 μs invariant (-0.10%)
/evaluation/n=128/value/sparse-form 49.182 μs (76.983 μs) ± 634.390 μs 49.072 μs (73.457 μs) ± 483.743 μs invariant (-0.22%)
/evaluation/n=384/value/dense-form 4.108 ms (4.153 ms) ± 150.843 μs 4.173 ms (4.214 ms) ± 156.814 μs invariant (1.58%)
/evaluation/n=384/value/dict-form 452.744 μs (461.440 μs) ± 21.722 μs 458.204 μs (466.279 μs) ± 9.396 μs invariant (1.21%)
/evaluation/n=384/value/model 168.234 μs (174.421 μs) ± 173.377 μs 169.316 μs (180.988 μs) ± 205.678 μs invariant (0.64%)
/evaluation/n=384/value/sparse-form 167.963 μs (175.457 μs) ± 187.248 μs 169.997 μs (179.389 μs) ± 209.129 μs invariant (1.21%)

@bernalde
bernalde merged commit ae5b49f into main Jun 18, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant