staticdata: close check-then-act race on newly_inferred - #62373
Merged
IanButterworth merged 1 commit intoJul 14, 2026
Conversation
`jl_push_newly_inferred` checked `newly_inferred` for NULL before taking `newly_inferred_mutex` without re-checking under the lock, while `jl_set_newly_inferred` swapped the global with no lock at all. A clear or replacement racing a push could dereference NULL or append to a replaced (orphaned) array. Take the mutex in `jl_set_newly_inferred` and re-check the array under the lock in `jl_push_newly_inferred`. Same defect shape as the `Partr.multiq_size` race (JuliaLang#62144). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
vtjnash
approved these changes
Jul 14, 2026
IanButterworth
marked this pull request as ready for review
July 14, 2026 07:51
IanButterworth
added
backport 1.12
Member
|
Thanks @IanButterworth ! Nice to have this fixed (and more importantly #62372) |
DilumAluthge
removed
the
merge me
KristofferC
pushed a commit
that referenced
this pull request
Jul 18, 2026
(cherry picked from commit 3ed74ae)
KristofferC
pushed a commit
that referenced
this pull request
Jul 18, 2026
(cherry picked from commit 3ed74ae)
KristofferC
removed
the
backport 1.13
KristofferC
pushed a commit
that referenced
this pull request
Jul 21, 2026
(cherry picked from commit 3ed74ae)
KristofferC
pushed a commit
that referenced
this pull request
Jul 21, 2026
(cherry picked from commit 3ed74ae)
KristofferC
pushed a commit
that referenced
this pull request
Jul 24, 2026
(cherry picked from commit 3ed74ae)
DilumAluthge
pushed a commit
that referenced
this pull request
Jul 25, 2026
(cherry picked from commit 3ed74ae)
KristofferC
pushed a commit
that referenced
this pull request
Aug 7, 2026
(cherry picked from commit 3ed74ae)
KristofferC
pushed a commit
that referenced
this pull request
Aug 8, 2026
(cherry picked from commit 3ed74ae)
KristofferC
pushed a commit
that referenced
this pull request
Aug 8, 2026
(cherry picked from commit 3ed74ae)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I asked Claude to find any similar bugs to #62372 and this was the only one it found in Base/src.
jl_push_newly_inferredcheckednewly_inferredfor NULL before takingnewly_inferred_mutexwithout re-checking under the lock, whilejl_set_newly_inferredswapped the global with no lock at all. A clear or replacement racing a push could dereference NULL or append to a replaced (orphaned) array. Take the mutex injl_set_newly_inferredand re-check the array under the lock injl_push_newly_inferred.