Keep source column when sources vector has one file - #1192
Open
JohnCobbler wants to merge 2 commits into
Open
Conversation
The single-source short-circuit in File(::Vector) forwarded only kw..., which omits the source keyword, so a one-element sources vector silently dropped the requested source column. Skip the short-circuit when source is set so the general path adds the column. Co-authored-by: Claude <noreply@anthropic.com>
Cleanup temp files after the JuliaData#1146 regression tests.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1192 +/- ##
=======================================
Coverage 90.79% 90.79%
=======================================
Files 9 9
Lines 2335 2335
=======================================
Hits 2120 2120
Misses 215 215 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
File(sources::Vector; source=...)short-circuits a one-element vector toFile(sources[1]; kw...), forwarding onlykw.... Thesourcekeyword is boundto its own parameter, so it is not part of
kwand gets dropped - a single-elementsourcesvector silently loses the requested source column, while the source-columninjection only runs in the multi-source path.
Skip the short-circuit when
sourceis set, so a one-element vector falls throughto the general path that adds the column. The
source === nothingfast path isunchanged.
Added regression tests for a single-element
sourcesvector: thesourcecolumnis present with
Symbol/String/Pairnames, and the no-sourcecase stillmatches the scalar
CSV.File(path)result.Fixes #1146