Trigger CI on tag pushes so deploydocs publishes versioned docs - #82
Merged
Conversation
The workflow only triggers on master pushes and PRs, never on tag pushes. As a result, when TagBot creates a release tag, no CI run fires against the tag, so deploydocs never publishes the versioned /vX.Y.Z/ directory and the /stable/ symlink never advances. This isn't actively biting right now because no new tag has been cut since 2023, but the next tag would silently fail to update the docs site. Preemptive fix. Adding tags: ['*'] matches the standard Documenter recommendation and the existing config in FinanceCore.jl, EconomicScenarioGenerators.jl, and TermLife.jl. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The CI workflow only triggers on master pushes and PRs, never on tag pushes. When TagBot creates a release tag, no CI run fires against the tag, so `deploydocs` never publishes the versioned `/vX.Y.Z/` directory and the `stable` symlink never advances.
This isn't actively biting today because no new tag has been cut since 2023 (current `/stable/` is at v2.5.0, matching the latest release), but the next tag would silently fail to update the docs site — same bug that has left FinanceModels at v4.17.1 and ActuaryUtilities at v5.2.1. Preemptive fix.
Adding `tags: ['*']` matches the standard Documenter recommendation and the existing config in `FinanceCore.jl`, `EconomicScenarioGenerators.jl`, and `TermLife.jl`.
Test plan
🤖 Generated with Claude Code