Skip to content
This repository was archived by the owner on Apr 27, 2026. It is now read-only.

add release notes for 0.9.12#1839

Merged
AdamISZ merged 1 commit into
masterfrom
release-notes-0.9.12
Apr 21, 2026
Merged

add release notes for 0.9.12#1839
AdamISZ merged 1 commit into
masterfrom
release-notes-0.9.12

Conversation

@AdamISZ

@AdamISZ AdamISZ commented Apr 15, 2026

Copy link
Copy Markdown
Member

Please read and review the notes, thanks. Ping @kristapsk

@AdamISZ

AdamISZ commented Apr 15, 2026

Copy link
Copy Markdown
Member Author

Also for the best will be if you gpg sign it, given my documented key loss/change

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR finalizes the 0.9.12 release by removing the dev suffix from core/package versions, bumping the JoinMarket-Qt GUI version, and adding the 0.9.12 release notes documentation.

Changes:

  • Set JM_CORE_VERSION and package version to 0.9.12 (non-dev release).
  • Bump JM_GUI_VERSION to 34 and update the Qt guide accordingly.
  • Add new release notes document for 0.9.12.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/jmbase/support.py Finalizes core version string for the 0.9.12 release.
scripts/joinmarket-qt.py Bumps JoinMarket-Qt GUI version constant to 34.
pyproject.toml Finalizes the package version to 0.9.12.
docs/release-notes/release-notes-0.9.12.md Adds the 0.9.12 release notes content.
docs/JOINMARKET-QT-GUIDE.md Updates documented “latest GUI version” to 34.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread docs/release-notes/release-notes-0.9.12.md Outdated
Comment thread docs/release-notes/release-notes-0.9.12.md
Comment thread docs/release-notes/release-notes-0.9.12.md Outdated
Comment thread docs/release-notes/release-notes-0.9.12.md Outdated
@kristapsk

Copy link
Copy Markdown
Member

Few nits. Will be able to gpg sign likely tomorrow.

Comment thread docs/release-notes/release-notes-0.9.12.md
Comment thread docs/release-notes/release-notes-0.9.12.md
Comment thread docs/release-notes/release-notes-0.9.12.md Outdated
@AdamISZ

AdamISZ commented Apr 15, 2026

Copy link
Copy Markdown
Member Author

Few nits. Will be able to gpg sign likely tomorrow.

Thank. Nbd on timing; I think (correct me if I'm wrong) I can just attach the signature to the release, after the event.

@kristapsk

Copy link
Copy Markdown
Member

Few nits. Will be able to gpg sign likely tomorrow.

Thank. Nbd on timing; I think (correct me if I'm wrong) I can just attach the signature to the release, after the event.

Yes. Recently had a situation where I added signature signed with a wrong key to one release, was able to change it later.

@AdamISZ

AdamISZ commented Apr 17, 2026

Copy link
Copy Markdown
Member Author

Ready to squash and merge according to me. LMK.

@MarnixCroes

Copy link
Copy Markdown
Contributor

LGTM

However, as this is the "final" release, it might be good to ship this release with deps with their latest versions, for example secp256k1. Which is now at v5 (2024-05-06), latest is v7.1 (2026-01-26).

@AdamISZ

AdamISZ commented Apr 17, 2026

Copy link
Copy Markdown
Member Author

LGTM

However, as this is the "final" release, it might be good to ship this release with deps with their latest versions, for example secp256k1. Which is now at v5 (2024-05-06), latest is v7.1 (2026-01-26).

As a general principle, not going to be doing updates to latest on deps since that could be all sorts of extra work, but worth checking this one specifically. Reading the secp release schedule, 0.7 was an API break, and 0.6 was mainly for MuSig. Won't update (though of course later developments of joinmarket here or elsewhere definitely would have to pay attention to it at some point).

@AdamISZ AdamISZ force-pushed the release-notes-0.9.12 branch from b3208db to 77a426c Compare April 20, 2026 15:35
@AdamISZ

AdamISZ commented Apr 20, 2026

Copy link
Copy Markdown
Member Author

Squashed. Will publish when @kristapsk OKs.

@kristapsk

Copy link
Copy Markdown
Member

Squashed. Will publish when @kristapsk OKs.

ACK

@AdamISZ AdamISZ merged commit 77a426c into master Apr 21, 2026
13 of 21 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants