Decouple TextToolbarStatus from iOS context menu visibility#3139
Decouple TextToolbarStatus from iOS context menu visibility#3139Vladimir Mazunin (mazunin-v-jb) wants to merge 4 commits into
TextToolbarStatus from iOS context menu visibility#3139Conversation
…ix leaks and incorrect behavior. Fixed zombie ComposeTextInputView after navigating back when context menu is shown on SelectionContainer Clean ups in the UIKitTextInputService.ios.kt
Andrei Salavei (ASalavei)
left a comment
There was a problem hiding this comment.
Just in case: we propagated isEditMenuShown because the edit menu can hide by itself (for instance when user taps outside the context menu) - in this case it's highly possible to have misaligned status: TextToolbarStatus with the real visibility of the context menu.
Please verify it won't be an issue in the standard use-case, like operating with Text Fields.
Yes, I've found a regression after textfields retesting unfortunately |
|
Looks like the regression isn't caused by changes here. |
Decouple
TextToolbarStatusfrom the native context menu on iOS visibility to fix leaks and incorrect behavior.Clean ups in the UIKitTextInputService.ios.kt
Since the
TextToolbar.statuswas tied withisEditingMenuShowflag, during back navigation there might be cases when TextToolbar.status reports as Hidden while the menu repositioning is happening on the CMPEditMenuView side.That's why
SelectionManagerdoesn't callTextToolbar.hide()(as it should during the back-navigating teardown), and the menu reappears once again, leaking theComposeTextInputViewin the view hierarchy.Fixes: CMP-9316 [ios]. context menu doesn't hide after backNavigation
Testing
Should be tested by QA, the case in the attached task
Release Notes
Fixes - iOS
SelectionContainer