Conversation
Added overflow-x hidden to the body to prevent out of bounds elements to cause horizontal scrolling Added a scrollbar-width: thin on every scrollbar purely for aesthetic reasons.
Fixed an issue with horizontal scroll
An option to remove the libraries section from the home screen as it is redundant with the top nav. I made a new UI section in the settings page, it may or may not be the most organized idea, let me know!
An option to remove the libraries section from the home screen as it is redundant with the top nav. I made a new UI section in the settings page, it may or may not be the most organized idea, let me know!
This reverts commit d2b26be.
… screen" This reverts commit f574891.
Added an option to remove the libraries section from the home screen
Added an objectFit: cover to the HeroDisplay Component so that the videos takes the whole space, also moved the z-index property as it was no being applied when not directly on the video component.
Changed the z-index of the buttons of the hero to not make them appear over the app bar
Fixed the videos in the hero banner not taking the whole height/width
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several changes to enhance the functionality and improve the documentation of the Nevu project. Key updates include transitioning from Bonjour to UDP Discovery for service discovery, adding new environment variables for configuration, updating Docker settings to support UDP ports, and refining the README for better clarity. Additionally, unused dependencies were removed, and new ones were added to support the updated functionality.
Service Discovery Updates:
BonjourwithUDP Discoveryfor service discovery inbackend/src/index.ts, enabling more robust UDP-based announcements. ([[1]](https://github.com/Ipmake/NevuForPlex/pull/57/files#diff-c20200a666b149a045e365999f581db8e04687cfc9569bdf4c9477cab954d324L10-L19),[[2]](https://github.com/Ipmake/NevuForPlex/pull/57/files#diff-c20200a666b149a045e365999f581db8e04687cfc9569bdf4c9477cab954d324L37-R49))LISTEN_PORTenvironment variable for flexibility in deployment configurations. ([backend/src/index.tsL597-R598](https://github.com/Ipmake/NevuForPlex/pull/57/files#diff-c20200a666b149a045e365999f581db8e04687cfc9569bdf4c9477cab954d324L597-R598))Docker Configuration Enhancements:
44201to the Dockerfile and corresponding Docker commands in the README for service discovery. ([[1]](https://github.com/Ipmake/NevuForPlex/pull/57/files#diff-dd2c0eb6ea5cfc6c4bd4eac30934e2d5746747af48fef6da689e85b752f39557R15),[[2]](https://github.com/Ipmake/NevuForPlex/pull/57/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5L42-R43),[[3]](https://github.com/Ipmake/NevuForPlex/pull/57/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5R57))Documentation Improvements:
PORT,LISTEN_PORT) and clarified formatting for better readability. ([README.mdR74-R86](https://github.com/Ipmake/NevuForPlex/pull/57/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5R74-R86))[[1]](https://github.com/Ipmake/NevuForPlex/pull/57/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5R2-R9),[[2]](https://github.com/Ipmake/NevuForPlex/pull/57/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5L21-R23))Dependency Management:
bonjour-service,multicast-dns,dns-packet, etc.) and added new ones (udp-discovery,obj-to-json,is2) inbackend/package-lock.jsonandbackend/package.jsonto support the updated service discovery mechanism. ([[1]](https://github.com/Ipmake/NevuForPlex/pull/57/files#diff-f89763fc11c1bc48ac3c7ce8a148fbbbc5c2062393ee78664a70273d714daf5cL14-L33),[[2]](https://github.com/Ipmake/NevuForPlex/pull/57/files#diff-f89763fc11c1bc48ac3c7ce8a148fbbbc5c2062393ee78664a70273d714daf5cR1277-R1303),[[3]](https://github.com/Ipmake/NevuForPlex/pull/57/files#diff-495707834ca4b862f9acdfbac70d279023d2c059da13db59594e61ed3354fed5L8-R18))Miscellaneous:
.gitignoreto exclude/www, ensuring frontend build artifacts are not included in version control. ([backend/.gitignoreR5](https://github.com/Ipmake/NevuForPlex/pull/57/files#diff-a99100e55e9705d815385682f3d3178e8a212e73f00ac68787d3fe1c4663afd6R5))